functional tests script #1928
functional tests script #1928
Conversation
| for r1, g1, b1, r2, g2, b2 in ((256, 0, 0, 0, 0, 0), (0, 256, 0, 0, 0, 0), (0, 0, 256, 0, 0, 0), | ||
| (0, 0, 0, 256, 0, 0), (0, 0, 0, 0, 256, 0), (0, 0, 0, 0, 0, 256)): |
There was a problem hiding this comment.
Shouldn't the 256 values be 255?
| import sys | ||
| from openrazer.client import DeviceManager | ||
| from openrazer.client import constants as razer_constants | ||
|
|
There was a problem hiding this comment.
A quick "about" section would be helpful. Things like use cases for this tool and expected invocation.
| print() | ||
|
|
||
|
|
||
| prompt = 'noprompt' not in sys.argv |
There was a problem hiding this comment.
I like to use argparse to handle passed in parameters. It also helps users understand how to use the tool. This is no a blocker though.
| if capability == "name": | ||
| print(f"device.name: {device.name}") | ||
| elif capability == "type": | ||
| print(f"device.type: {device.type}") | ||
| elif capability == "firmware_version": | ||
| print(f"device.firmware_version: {device.firmware_version}") | ||
| elif capability == "serial": | ||
| print(f"device.serial: {device.serial}") |
There was a problem hiding this comment.
Putting all of these bit of info into a get_basic_info function could be helpful for showing information that is expected. I think if any of these are missing then that should be a red flag that something isn't working quite right. One could imaging an output like the following.
Name: Death Adder Gen X
Device Type: Mouse
Firmware Version: MISSING!
Serial Number: MISSING!
Not sure if that sort of info is outside the scope. If so, ignore me. 😄
For running automated tests of the kernel module I've hacked this script together (some capabilities still need to be implemented).
Can you give me some early feedback, might also be good to reference this in #1919 as one of the checks when adding support for a new feature/device.