Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom effect support for Razer Book 2020 #1959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Khraut
Copy link

@Khraut Khraut commented Nov 21, 2022

I own this device and can confirm that it is working.

@z3ntu
Copy link
Member

z3ntu commented Jan 9, 2023

So wave and custom effect you tested but you also added starlight but not to the daemon. Can you please also add that to the daemon or remove from the driver if it doesn't work?

Also please set some proper email address in your git setup, not you@example.com . Even if it's just this github noreply email address that it uses as placeholder

@z3ntu
Copy link
Member

z3ntu commented Apr 27, 2023

@Khraut Any update on this?

@Khraut
Copy link
Author

Khraut commented May 8, 2023

@z3ntu Sorry was busy in the last time, I will have a look!

@z3ntu
Copy link
Member

z3ntu commented Aug 20, 2023

bump again

@Khraut
Copy link
Author

Khraut commented Jan 9, 2024

Hello again, i finally managed to go after this.

So wave and custom effect you tested but you also added starlight but not to the daemon. Can you please also add that to the daemon or remove from the driver if it doesn't work?

I added starlight to the daemon and can confirm that it is working. But there is something strange, maybe you know more about this:

The starlight supports only one color (green). And the ripple effect is now gone, but I can't remember if that worked beforehand.

Is there something that I am missing out?

Thank you in advance!

@carsonbird
Copy link

Hmm, looks like the alpine variant failed to build. I can't see the details for some reason. @Khraut any luck? It's probably a simple fix before we can merge this in.

@z3ntu
Copy link
Member

z3ntu commented Mar 3, 2024

This is still outstanding.

Also please set some proper email address in your git setup, not you@example.com . Even if it's just this github noreply email address that it uses as placeholder

The starlight supports only one color (green).

That sounds unexpected. Good that it works at least in green which shows the packet itself has the correct command etc. Curious if the firmware of this device is just buggy or if we send the wrong packet somehow.

And the ripple effect is now gone, but I can't remember if that worked beforehand.

Gone as in how? It's still listed in the daemon methods it seems so it should show up in polychromatic/RazerGenie at least.

Also please see these CI failures

FAILED: Razer Book 13 (2020)
0x26a Has sysfs 'matrix_effect_breath' but no capability set: 'lighting_breath_single'

FAILED: Razer Book 13 (2020)
0x26a Has one of these sysfs ['matrix_effect_starlight'] but none of these capabilities: ['lighting_starlight_random', 'lighting_starlight_single', 'lighting_starlight_dual']

"capabilities" here are the corresponding methods in METHODS in the daemon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants