Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Razer BlackWidow V4 X #2209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tostivintc
Copy link

@tostivintc tostivintc commented Feb 25, 2024

Hi,

I've successfully tested the RGB with polychromatic, but not yet the macro.

Fixes #2130

driver/razerkbd_driver.c Outdated Show resolved Hide resolved
@z3ntu
Copy link
Member

z3ntu commented Mar 3, 2024

I've successfully tested the RGB with polychromatic, but not yet the macro.

If all the RGB works that's good!

Don't worry about the macro support, it's barely supported anyways and I'll probably remove the support completely at some point in favor of using e.g. https://github.com/sezanzeb/input-remapper

@squishypinkelephant
Copy link

daemon/openrazer_daemon/hardware/keyboards.py is missing DEVICE_IMAGE and will cause errors when using polychromatic.
otherwise RGB works as expected.

@z3ntu
Copy link
Member

z3ntu commented Apr 4, 2024

@tostivintc Any update on this?

@tostivintc tostivintc force-pushed the master branch 6 times, most recently from 17699dc to 7b98650 Compare April 8, 2024 15:35
@tostivintc
Copy link
Author

I have added a device image link as requested and rebase on master head. But now I'm getting poll_rate error at polychromatic start. I need to dig to understand the issue.

@z3ntu
Copy link
Member

z3ntu commented Apr 8, 2024

What error do you get?

Btw the diff looks good now.

@tostivintc
Copy link
Author

The error I got at polychromatic start:

Traceback (most recent call last):
  File ’/usr/bin/polychromatic-controller’, line 311, in _change_tab
    tab_objects[index].set_tab()
  File ’/usr/lib/python3/dist-packages/polychromatic/controller/devices.py’, line 90, in set_tab
    device_list = self.middleman.get_devices()
  File ’/usr/lib/python3/dist-packages/polychromatic/middleman.py’, line 151, in get_devices
    self._reload_device_cache_if_empty()
  File ’/usr/lib/python3/dist-packages/polychromatic/middleman.py’, line 122, in _reload_device_cache_if_empty
    device_list = backend.get_devices()
  File ’/usr/lib/python3/dist-packages/polychromatic/backends/openrazer.py’, line 153, in get_devices
    devices.append(self._get_device(rdevice))
  File ’/usr/lib/python3/dist-packages/polychromatic/backends/openrazer.py’, line 255, in _get_device
    main_zone.options.append(self._get_poll_rate_option(rdevice))
  File ’/usr/lib/python3/dist-packages/polychromatic/backends/openrazer.py’, line 1318, in _get_poll_rate_option
    current_rate = int(rdevice.poll_rate)
AttributeError: ’RazerKeyboard’ object has no attribute ’poll_rate’

And driver/dmesg error when a write is done on sysfs's poll_rate:

[175298.609439] razerkbd: Command not supported. status: 05 transaction_id.id: 1f remaining_packets: 00 protocol_type: 00 data_size: 02, command_class: 00, command_id.id: 40 Params: 00100000000000000000000000000000 .

@z3ntu
Copy link
Member

z3ntu commented Apr 11, 2024

Does Synapse on Windows allow you to the change the polling rate of the device? The firmware is saying the command is not supported so the device quite explicitly says this doesn't work.

@nfnvsc
Copy link

nfnvsc commented Apr 11, 2024

@z3ntu I just checked on Synapse (on Windows) and I cannot change the polling rate of the Blackwidow v4 X

@z3ntu
Copy link
Member

z3ntu commented Apr 12, 2024

Then remove polling rate support from this PR? Both driver and daemon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for Blackwidow V4 X
4 participants