Add support for Razer BlackWidow V3 Pro (Wireless) #2231
Conversation
lissyx
force-pushed
the
add_blackwidow_v3_pro_wireless
branch
from
9aa084d
to
f0e60e2
Compare
| 'set_custom_effect', 'set_key_row', 'get_game_mode', 'set_game_mode', 'get_macro_mode', 'set_macro_mode', | ||
| 'get_macro_effect', 'set_macro_effect', 'get_macros', 'delete_macro', 'add_macro', | ||
| 'set_starlight_random_effect', 'set_starlight_single_effect', 'set_starlight_dual_effect', | ||
| 'set_ripple_effect', 'set_ripple_effect_random_colour', |
There was a problem hiding this comment.
So as commented in the previous PR, I've added it and:
rippledoes not work on wireless OR when I plug the keyboard- same for
reactiveeffect, I see nothing happening in both cases
There was a problem hiding this comment.
So you're saying both ripple and reactive effects also don't work in Wired mode? If it doesn't maybe we should remove it from both Wireless and Wired?
There was a problem hiding this comment.
That was at least my experience when I tested the latest PPA version available (3.7.0 I think), on my laptop (ubuntu 23.10). All other effects were doing something, except those two. I am unsure whether it is supposed to be working or not, though.
There was a problem hiding this comment.
(also reproduced when using current driver and daemon from git master, with polychromatic-controller, the effect was selectable but nothing would happen and no error reported anywhere as much as I can tell)
There was a problem hiding this comment.
I'd say you should add a commit to remove those effects from the Wired version, and not add them in the Wireless version in the first place.
There was a problem hiding this comment.
ok but which timeout? I dont see anything obvious in razer_attr_write_matrix_effect_custom
There was a problem hiding this comment.
Those?
+ case USB_DEVICE_ID_RAZER_BLACKWIDOW_V3_PRO_WIRELESS:
+ *report_index = 0x02;
+ *response_index = 0x02;
+ *wait_min = RAZER_BLACKWIDOW_V3_WIRELESS_WAIT_MIN_US;
+ *wait_max = RAZER_BLACKWIDOW_V3_WIRELESS_WAIT_MAX_US;
+ break;
There was a problem hiding this comment.
yes, wait_min / wait_max there. Update both values to be e.g. 10 times as high as they are right now
There was a problem hiding this comment.
Sorry for the delay, I'll try things
There was a problem hiding this comment.
Unfortunately, it does not help. I tried hacking a few things, but I dont really have much time to investigate more. Happy to test any suggestion though.
FTR, when I toggle "Ripple" in Polychromatic UI, not only it does not work on the keyboard, but the next effect I select is also not working ; I have to select again a different one before all effects (except Ripple) works.
|
If you rebase on git master then the CI shouldn't be broken anymore. |
lissyx
force-pushed
the
add_blackwidow_v3_pro_wireless
branch
2 times, most recently
from
fd21635
to
7d12e88
Compare
lissyx
force-pushed
the
add_blackwidow_v3_pro_wireless
branch
from
7d12e88
to
a445cd6
Compare
lissyx
force-pushed
the
add_blackwidow_v3_pro_wireless
branch
from
a445cd6
to
e912287
Compare
Co-authored-by: YoMamasNerd <jonas@thiele-eisele.de>
lissyx
force-pushed
the
add_blackwidow_v3_pro_wireless
branch
from
e912287
to
704fbed
Compare
@z3ntu Rebased against current
masterand looks to be working for me (aside from ripple?)Fixes #1279