Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - Remove unused dependency maven-compat (#499) #500

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

khmarbaise
Copy link
Contributor

@khmarbaise khmarbaise commented Feb 7, 2023

Fixes #499

@timtebeek timtebeek merged commit f70199b into openrewrite:main Feb 7, 2023
@timtebeek
Copy link
Contributor

Thanks yet again! Really appreciate the help. You're welcome to skip creating an issue if that helps. We can log the rational behind the changes in the pull request just the same.

@khmarbaise khmarbaise deleted the issue-499 branch February 8, 2023 17:52
@khmarbaise
Copy link
Contributor Author

You're welcome. Glad to help.
You are not assigning the issues to a milestone? That would give a good release notes summary for that plugin? I'm fine with going via issue.. Or do you maintain the release notes in a different way?

@timtebeek
Copy link
Contributor

We probably should start assigning issues to milestones, but as far as I'm aware we've not automated much about our release process yet, especially for the Maven plugin unfortunately. I'll see what that can bring us for the next release, which we expect in the next couple of days. At the very least I'll assign the work you've done to the next milestone, and be sure to credit that when it gets to writing the release notes. Much appreciated!

And I'm curious: have you started exploring applying OpenRewrite to any of your projects? Or seen applications for changes in bulk? Happy to talk through the options there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove unused dependency maven-compat
2 participants