Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a defined order for projectMap #552

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek added the bug Something isn't working label May 8, 2023
@timtebeek timtebeek requested review from rpau and sambsnyd May 8, 2023 19:24
@timtebeek timtebeek self-assigned this May 8, 2023
@timtebeek
Copy link
Contributor Author

Going on an instinct here, and this has not been tested. Similar change based off on what I saw in openrewrite/rewrite#3155

@timtebeek
Copy link
Contributor Author

This is based on the knowledge that the input projects from mavenSession.getProjects() here has been sorted:

/**
 * These projects have already been topologically sorted in the {@link org.apache.maven.Maven} component before
 * being passed into the session. This is also the potentially constrained set of projects by using --projects
 * on the command line.
 */
private List<MavenProject> projects;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants