Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy plugin docs to GitHub Pages #608

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Deploy plugin docs to GitHub Pages #608

merged 5 commits into from
Jul 27, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

Deploy plugin docs to GitHub Pages at
https://openrewrite.github.io/rewrite-maven-plugin/plugin-info.html

What's your motivation?

We want to link to the generated docs, such that they are always up to date.

Anything in particular you'd like reviewers to focus on?

Would we want to swap for a different style?
Would we want to limit produced pages through a site.xml?

Any additional context

Intended to mostly replace: https://docs.openrewrite.org/reference/rewrite-maven-plugin
https://github.com/openrewrite/rewrite-docs/blob/master/reference/rewrite-maven-plugin.md

@timtebeek timtebeek added the documentation Improvements or additions to documentation label Jul 27, 2023
@timtebeek timtebeek self-assigned this Jul 27, 2023
@timtebeek timtebeek temporarily deployed to github-pages July 27, 2023 07:41 — with GitHub Actions Inactive
@timtebeek
Copy link
Contributor Author

For any next such deployment, you'll want set the GitHub Pages source to GitHub Actions.
image

Next in environments, remove the branch protections for deployment to GitHub Pages, or at least while testing on a pull request; after a merge we only deploy from tags.

Copy link
Contributor

@mike-solomon mike-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re awesome! Thanks for setting this up. Looks good to me

@timtebeek timtebeek merged commit cda60ac into main Jul 27, 2023
1 check passed
@timtebeek timtebeek deleted the tim/deploy_github_pages branch July 27, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants