Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse ExecutionContext for ResourceParser #683

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Reuse ExecutionContext for ResourceParser #683

merged 1 commit into from
Dec 11, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

Pass the existing ExecutionContext into ResourceParser, instead of creating a new InMemoryExecutionContext.

What's your motivation?

Reuse any ParsingEventListeners or Consumer<Throwable> registered on the original ExecutionContext.
Fixes #622

Any additional context

@timtebeek timtebeek self-assigned this Dec 11, 2023
@timtebeek timtebeek added the enhancement New feature or request label Dec 11, 2023
@timtebeek timtebeek mentioned this pull request Dec 11, 2023
Closed
@timtebeek timtebeek merged commit 24ddb24 into main Dec 11, 2023
1 check passed
@timtebeek timtebeek deleted the reuse-execution-context-for-resource-parsing branch December 11, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden approved these changes

@joanvr joanvr joanvr approved these changes

Assignees

@timtebeek timtebeek

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing events not published for resources parsed with ResourceParser
3 participants
@timtebeek @knutwannheden @joanvr