Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting AddDependency invocations to set acceptTransitive=true, mat… #323

Merged

Conversation

nmck257
Copy link
Contributor

@nmck257 nmck257 commented Mar 21, 2023

…ching behavior prior to openrewrite/rewrite#2944

@nmck257
Copy link
Contributor Author

nmck257 commented Mar 21, 2023

test failures look unrelated - java file transformations for cucumber

@timtebeek
Copy link
Contributor

Went ahead and merged #322 ; not worth debugging cucumber at this stage. Could you resolve the conflicts? (getting late here)

timtebeek added a commit to cucumber/cucumber-jvm-migration that referenced this pull request Mar 21, 2023
@nmck257
Copy link
Contributor Author

nmck257 commented Mar 21, 2023

Yep, will do when I'm next online

@nmck257
Copy link
Contributor Author

nmck257 commented Mar 22, 2023

de-conflicted

@timtebeek timtebeek added the enhancement New feature or request label Mar 22, 2023
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thank you!

@timtebeek timtebeek merged commit 2ebfc49 into openrewrite:main Mar 22, 2023
@nmck257 nmck257 deleted the feature/AddDependency-acceptTransitive branch March 22, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants