Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifyNoInteractions should not be removed #324

Conversation

tmontovaneli
Copy link
Contributor

By running the recipe, statements importing this method are removed.

This method still is in Mockito and is not deprecated.

@timtebeek timtebeek added the bug Something isn't working label Mar 22, 2023
@timtebeek timtebeek merged commit 4948f08 into openrewrite:main Mar 22, 2023
@timtebeek
Copy link
Contributor

Thanks a lot for taking the time not only to report the issue, but immediately provide a fix as well. Much appreciated!
We typically release every two to three weeks; until then you can already try this out through our snapshot versions.

@harsh-pamnani
Copy link

Should we also include clearInvocations method along with it? We faced issues with that method as well and it is not deprecated in Mockito.

timtebeek added a commit that referenced this pull request Mar 22, 2023
@timtebeek
Copy link
Contributor

@harsh-pamnani Thanks for chiming in! Added that in a6829b2

@harsh-pamnani
Copy link

Awesome. Thanks @timtebeek

@timtebeek
Copy link
Contributor

No problem; thanks for reporting these two fixes! Hope you enjoy the updated Mockito tests. :)

And any more reports & fixes always welcome!

@tmontovaneli tmontovaneli deleted the tmontovaneli/verify-no-interactions-should-not-be-clean branch March 22, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants