Alek/parameterized test

[AlekSimpson]

What's changed?

Adds a recipe to update @Test to @ParameterizedTest under certain conditions

What's your motivation?

Closes #314

Anything in particular you'd like reviewers to focus on?

The import statement for @ParameterizedTest is not being added when I run the tests. I've included the classpath and used all the necessary import methods.

Anyone you would like to review specifically?

@timtebeek

Checklist

• I've added unit tests to cover both positive and negative cases
• I've added the license header to any new files through ./gradlew licenseFormat
• I've used the IntelliJ auto-formatter on affected files
• I've updated the documentation (if applicable)

[knutwannheden]

@AlekSimpson I think the hints I provided should help you make progress. The problem is that the JUnit API is split across multiple artifacts and you need to add them all explicitly to the classpath.

[AlekSimpson]

I updated the code with your suggested changes. Two tests are still failing, one fails because there is one extra space added at the start of the lines with the annotations and the method declaration. I'm not sure why that extra space is being included. My only guess is it has something to do with the .addAnnotation() coordinate line because that is the coordinate that test would be using.

The other test fails because when I try and reorder the annotations so that the @ParameterizedTest is on top it correctly does that but when it gets converted back into the code the annotations are on the same line (ex: @ParameterizedTest@SourceValue(..)).

[AlekSimpson]

With the newest changes I made today all the tests are passing. I'm not sure why the checks on the ci build are still failing.

[timtebeek]

With the newest changes I made today all the tests are passing. I'm not sure why the checks on the ci build are still failing.

You were missing the license headers; I've gone ahead and fixed that in c5c11bb ; it's also part of the checklist above.

[timtebeek]

Some quick suggestions for improvement

[timtebeek]

Thanks a lot for this effort! I've added a polish commit to simplify things a bit:

• remove @Test through RemoveAnnotationVisitor, to better reuse edge case handling already present there
• always add @Parameterized at the start, removing the need for coordinates.replace() and reorderAnnotations
• removes the call to maybeAutoFormat which is no longer needed now
• reapplied a formatter to the source code