Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alek/including new recipes in recipe list best practices #367

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

AlekSimpson
Copy link
Contributor

What's changed?

Accidentally placed the AddParameterizedTestAnnotation and RemoveDuplicateTestTemplate recipes in the JUnit4 to JUnit5 migration list, they should have been in the best practices list. I fixed that in the yml.

What's your motivation?

This comment from the last PR to do this last week.

Any additional context

This discussion is where this comes from.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@sambsnyd sambsnyd merged commit 3c60d66 into main Jun 26, 2023
1 check passed
@sambsnyd sambsnyd deleted the alek/includingNewRecipesInRecipeListBestPractices branch June 26, 2023 21:54
@sambsnyd
Copy link
Member

Thanks @AlekSimpson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants