Limit RemoveIsMatcher to invocations within assertThat
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
requested changes
Jul 8, 2023
src/test/java/org/openrewrite/java/testing/hamcrest/RemoveIsMatcherTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/hamcrest/RemoveIsMatcher.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/hamcrest/RemoveIsMatcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/hamcrest/RemoveIsMatcherTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/hamcrest/RemoveIsMatcherTest.java
Show resolved
Hide resolved
timtebeek
changed the title
RemoveIsMatcher to invocations within assertThat
…tcherTest.java Co-authored-by: Tim te Beek <tim@moderne.io>
…tcher.java Co-authored-by: Tim te Beek <tim@moderne.io>
…tcherTest.java Co-authored-by: Tim te Beek <tim@moderne.io>
…tcherTest.java Co-authored-by: Tim te Beek <tim@moderne.io>
…tcherTest.java Co-authored-by: Tim te Beek <tim@moderne.io>
timtebeek
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR fixes an issue where the recipe that removed
is()invocations would remove them even when they were not found directly inside of anassertThatinvocation.What's your motivation?
#365
Anything in particular you'd like reviewers to focus on?
I added two tests based off of the last comment on the ticket. Both tests now pass in this PR, so I think the bug should be fixed. I think how I implemented the fix shouldn't interfere with any other parts of the recipe.
Anyone you would like to review specifically?
@timtebeek
Any additional context
Checklist
./gradlew licenseFormat