Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed containsInRelativeOrder from yaml list #376

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

AlekSimpson
Copy link
Contributor

What's changed?

The containsInRelativeOrder matcher recipe has been removed from the hamcrest.yml list.

What's your motivation?

this issue

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

It seems that there is currently no direct replacement for the hamcrest matcher containsInRelativeOrderin AssertJ. The closest method in AssetJ would be containsExactlyInOrder but these two methods are not quite the same.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@AlekSimpson AlekSimpson self-assigned this Jul 10, 2023
@timtebeek
Copy link
Contributor

I'm guessing the test will fail; that needs to updated as well.

@sambsnyd sambsnyd merged commit d409434 into main Jul 10, 2023
1 check passed
@sambsnyd sambsnyd deleted the alek/RemoveContainsInRelativeOrderFromYaml branch July 10, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants