More Hamcrest Migrations for Number Matchers #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR modifies the existing Hamcrest to AssertJ migration recipe to allow for more number matchers to be migrated.
What's your motivation?
#357
Anything in particular you'd like reviewers to focus on?
So I added support for
closeTo
but when I was looking through the list of matchers that related to numbers I couldn't find any others that weren't already supported. Maybe I'm not looking at the right documentation. Let me know if there were any other number matchers you were maybe expecting to see here.Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
At first I had created a dedicated recipe for
closeTo
but then realized theHamcrestMatcherToAssertJ
recipe did most of what needed to be done already.Checklist
./gradlew licenseFormat