Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate assertEquals with array parameter to assertArrayEquals #384

Merged

Conversation

puskarpeter
Copy link
Contributor

@puskarpeter puskarpeter commented Jul 19, 2023

What's changed?

Added a test case to cover the mentioned use case.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

- assertEquals in JUnit4 accepts Object[], to preserve the behaviour we need to rewrite it into assertArrayEquals

Signed-off-by: Peter Puškár <peter.puskar@elisapolystar.com>
@timtebeek timtebeek linked an issue Jul 19, 2023 that may be closed by this pull request
@timtebeek timtebeek added the enhancement New feature or request label Jul 19, 2023
Signed-off-by: Peter Puškár <peter.puskar@elisapolystar.com>
Signed-off-by: Peter Puškár <peter.puskar@elisapolystar.com>
@puskarpeter puskarpeter marked this pull request as ready for review July 20, 2023 08:03
@timtebeek timtebeek merged commit b4db150 into openrewrite:main Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

JUnit 4 -> JUnit 5 migration - assertArrayEquals
2 participants