Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xmlunit-legacy instead of xmlunit #386

Merged
merged 4 commits into from
Jul 23, 2023

Conversation

puskarpeter
Copy link
Contributor

@puskarpeter puskarpeter commented Jul 21, 2023

  • xmlunit is not compatible with JUnit5 hence we need to migrate it

What's changed?

Package migration for xmlunit, no code changes since xmlunit-legacy provides compatibility between versions 2.x and 1.x

What's your motivation?

JUnit5 compatibility. XMLUnit 1.6 would not compile, XMLUnit legacy everything works with JUnit5 as expected.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

https://github.com/xmlunit/xmlunit/#requirements

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

- xmlunit is not compatible with JUnit5 hence we need to migrate it

Signed-off-by: Peter Puškár <peter.puskar@elisapolystar.com>
Signed-off-by: Peter Puškár <peter.puskar@elisapolystar.com>
Signed-off-by: Peter Puškár <peter.puskar@elisapolystar.com>
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @puskarpeter

@timtebeek timtebeek added the recipe Recipe request label Jul 22, 2023
@timtebeek timtebeek merged commit 4893495 into openrewrite:main Jul 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants