Resolve issues with SimplifyChainedAssertJAssertion #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
changed the title
timtebeek
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Wanted to additionally cover #398 (comment) and decided to then do a few more thorough changes such that it's clearer what we're doing where and why. The fix for the issue where we replaced the method invocations is now in the extractEitherArgument method.
timtebeek
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR fixes the issues highlighted in #398
What's your motivation?
#398
Anyone you would like to review specifically?
@timtebeek
Checklist
./gradlew licenseFormat