Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMockit to Mockito Recipe - Handle Argument Matchers and Void Methods #419

Merged
merged 13 commits into from
Oct 30, 2023
Merged

JMockit to Mockito Recipe - Handle Argument Matchers and Void Methods #419

merged 13 commits into from
Oct 30, 2023

Conversation

tinder-dthomson
Copy link
Contributor

@tinder-dthomson tinder-dthomson commented Oct 28, 2023 •
edited

What's changed?

  • Added handling for Argument Matchers.
  • Added handling for Void methods in Expectations blocks.

What's your motivation?

Continuation of #418.

This recipe is still incomplete, pending handling of times, minTimes, and maxTimes fields of Expectations blocks in a subsequent PR.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@tinder-dthomson tinder-dthomson changed the title JMockit to Mockito Recipe - handle void methods JMockit to Mockito Recipe - Handle Argument Matchers and Void Methods Oct 30, 2023
@tinder-dthomson tinder-dthomson marked this pull request as ready for review October 30, 2023 18:11
timtebeek
timtebeek approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I like how clear things are in review with these incremental changes.

@timtebeek timtebeek merged commit 0d1c3ac into openrewrite:main Oct 30, 2023
1 check passed
@tinder-dthomson tinder-dthomson deleted the jmockit-expectations-void branch October 31, 2023 05:39
@tinder-dthomson tinder-dthomson mentioned this pull request Oct 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tinder-dthomson @timtebeek