Do not change visibility in UpdateTestAnnotation; use TestsShouldNotBePublic instead
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
changed the title
UpdateTestAnnotation; use TestsShouldNotBePublic instead
timtebeek
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Thanks a lot for taking this on @magicwerk ! You can try it out from our snapshot versions shortly; we'll follow up with a release in the next week or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixes #441
UpdateTestAnnotation does not change the visibility modifier anymore.
I updated the test as needed.
I removed the following 2 tests in UpdateTestAnnotationTest as they make no sense after the change:
privateToPackageVisibility()
protectedToPackageVisibility()