Reduce public dependencies #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiding error variants from a library's public error type to prevent dependency updates from becoming breaking changes. We can add `UrdfErrorKind` enum or `is_*` methods that indicate the kind of error if needed, but don't expose dependencies' types directly in the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding error variants from a library's public error type to prevent dependency updates from becoming breaking changes.
We can add
UrdfErrorKindenum oris_*methods that indicate the kind of error if needed, but don't expose dependencies' types directly in the public API.This reduces public dependencies from 3 (
serde,serde-xml-rs,RustyXML) to 1 (serde).Refs: dtolnay/thiserror#50