-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mkdocs 1.2.1 #327
Use mkdocs 1.2.1 #327
Conversation
Bumps [mkdocs](https://github.com/mkdocs/mkdocs) from 1.1.2 to 1.2.1. - [Release notes](https://github.com/mkdocs/mkdocs/releases) - [Commits](mkdocs/mkdocs@1.1.2...1.2.1) --- updated-dependencies: - dependency-name: mkdocs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [mkdocstrings](https://github.com/mkdocstrings/mkdocstrings) from 0.13.6 to 0.15.2. - [Release notes](https://github.com/mkdocstrings/mkdocstrings/releases) - [Changelog](https://github.com/mkdocstrings/mkdocstrings/blob/master/CHANGELOG.md) - [Commits](mkdocstrings/mkdocstrings@0.13.6...0.15.2) --- updated-dependencies: - dependency-name: mkdocstrings dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
To solve that problem, add
in mkdocs.yml Then this will result in:
Which I don't understand why it's required yet: |
thanks, added a separate mkdocs.test.yml, because I wanted to avoid breaking links on the cloudflare test deploys - it gives the error that the mkdocstring pr gives on its own, though - maybe we can fix that there & do mkdocs-1.2 afterwards |
This is all resolved now via #332 and #333. In mkdocs 1.2.1 there was a requirement to specify NB: Cloudflare Pages lets you discern production from non-production branches. If we wanted to do this, I think it would be possible via:
Alternatively, if it's possible to set custom environment variables for testing and production within Cloudflare Pages, then that would remove the need for the wrapper: we'd just need the |
Nice! |
I suspect that upgrading mkdocs & mkdocstrings at the same time might fix CI - let's see.