Upgrades `jest` to v27 #1301

tmarkley · 2022-03-01T04:30:04Z

Description

Upgrades jest from v26.4.2 to v27.5.1.
- CHANGELOG
- v27 introduces breaking changes that have to be addressed.
Upgrades testing-related dependencies, removes unused dependency babel-plugin-istanbul, and replaces jest-environment-jsdom-thirteen with the built-in jest-environment-jsdom.
Skips a few flaky tests that require additional investigation.

Issues Resolved

Prerequisite for addressing #1231

Check List

tmarkley · 2022-03-01T18:19:30Z

Note: the WhiteSource Security Check is incorrect; a version of ansi-regex was removed, so that CVE was not introduced in this commit (it existed before: #1084).

kavilla

Can we, if you have already, check on 1.x the runInBand doesn't cause any issue? I believe it did but perhaps it's worth 1 more pass. If so would it be worth to have 1 commit or PR updating the github workflow another to upgrading jest. Since this can't be backported.

.eslintrc.js

.github/workflows/pr_check_workflow.yml

tmarkley · 2022-03-02T16:13:43Z

Can we, if you have already, check on 1.x the runInBand doesn't cause any issue? I believe it did but perhaps it's worth 1 more pass. If so would it be worth to have 1 commit or PR updating the github workflow another to upgrading jest. Since this can't be backported.

Yeah I can split this up into two PRs! And yes I can check 1.x and see how things work.

kavilla · 2022-03-02T20:43:30Z

src/core/server/http/integration_tests/request.test.ts

@@ -180,24 +187,25 @@ describe('OpenSearchDashboardsRequest', () => {

  describe('events', () => {
    describe('aborted$', () => {
-      it('emits once and completes when request aborted', async (done) => {
+      // Flaky test
+      it.skip('emits once and completes when request aborted', async () => {


are these flaky only in the CI? I was able to get the passing locally.

When you pulled the PR down it consistently passed locally for you? Sometimes it would pass, sometimes it would fail for me.

Could you please elaborate on the failure?

The test would timeout after 30 seconds.

I see, I believe we have to make an update still: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1301/files#r818949420

I still couldn't get this one to pass. This test doesn't use fake timers.

This might be related to the supertest functions used, but I haven't narrowed it down.

This might be related to the supertest functions used, but I haven't narrowed it down.

If you aren't able to for this PR could we create a follow up issue to look into it? I don't want to block this PR any longer because it prevents an improvement that brings in more value than this test can provide but I don't want to forget about this test.

Added a comment for this specifically in the issue we already have open for these types of cases: #5

src/core/server/http/integration_tests/request.test.ts

src/core/public/plugins/plugins_service.test.ts

* Upgrades `jest` from v26.4.2 to v27.5.1. * [CHANGELOG](https://github.com/facebook/jest/blob/v27.5.1/CHANGELOG.md) * v27 introduces breaking changes that have to be addressed. * Upgrades testing-related dependencies, removes unused dependency `babel-plugin-istanbul`, and replaces `jest-environment-jsdom-thirteen` with the built-in `jest-environment-jsdom`. This is a prerequisite to resolving opensearch-project#1231 Signed-off-by: Tommy Markley <markleyt@amazon.com>

kavilla

Awesome thanks! LGTM. Just the comment about creating a follow up issue. And probably something will need to be included as a heads up here: #1206?

tmarkley added test:unit test:integration dependencies Pull requests that update a dependency file v2.0.0 labels Mar 1, 2022

tmarkley requested a review from a team as a code owner March 1, 2022 04:30

tmarkley force-pushed the test_workflow_performance branch from 45ec3a3 to 4375353 Compare March 1, 2022 16:24

tmarkley mentioned this pull request Mar 1, 2022

Upgrades TypeScript to 4.1, simplifies jest config #1230

Closed

7 tasks

ananzh previously approved these changes Mar 2, 2022

View reviewed changes

tmarkley dismissed ananzh’s stale review via 8da108a March 2, 2022 00:53

tmarkley force-pushed the test_workflow_performance branch from 4375353 to 8da108a Compare March 2, 2022 00:53

tmarkley requested review from ananzh and kavilla March 2, 2022 00:54

ananzh previously approved these changes Mar 2, 2022

View reviewed changes

kavilla reviewed Mar 2, 2022

View reviewed changes

.eslintrc.js Show resolved Hide resolved

.github/workflows/pr_check_workflow.yml Outdated Show resolved Hide resolved

tmarkley dismissed ananzh’s stale review via e6fb6af March 2, 2022 16:53

tmarkley force-pushed the test_workflow_performance branch 2 times, most recently from e6fb6af to e670833 Compare March 2, 2022 16:54

tmarkley changed the title ~~Upgrades jest to v27, simplifies GitHub workflow~~ Upgrades jest to v27 Mar 2, 2022

tmarkley force-pushed the test_workflow_performance branch 2 times, most recently from ec39ceb to 2ca8c3c Compare March 2, 2022 17:16

tmarkley requested review from kavilla, ananzh and ashwin-pc March 2, 2022 17:55

tmarkley force-pushed the test_workflow_performance branch from 2ca8c3c to 2645102 Compare March 2, 2022 19:29

kavilla reviewed Mar 2, 2022

View reviewed changes

tmarkley requested review from kavilla and AMoo-Miki March 2, 2022 23:13

ananzh previously approved these changes Mar 3, 2022

View reviewed changes

AMoo-Miki reviewed Mar 3, 2022

View reviewed changes

src/core/server/http/integration_tests/request.test.ts Outdated Show resolved Hide resolved

kavilla reviewed Mar 3, 2022

View reviewed changes

src/core/public/plugins/plugins_service.test.ts Outdated Show resolved Hide resolved

tmarkley dismissed ananzh’s stale review via eeb5144 March 3, 2022 20:56

tmarkley force-pushed the test_workflow_performance branch from 2645102 to eeb5144 Compare March 3, 2022 20:56

tmarkley requested review from AMoo-Miki, ananzh and kavilla March 3, 2022 20:59

kavilla approved these changes Mar 3, 2022

View reviewed changes

tmarkley mentioned this pull request Mar 3, 2022

[PURIFY] Fix broken / transient integration and functional test cases #5

Closed

4 tasks

ananzh approved these changes Mar 3, 2022

View reviewed changes

tmarkley merged commit 082f44a into opensearch-project:main Mar 3, 2022

tmarkley deleted the test_workflow_performance branch March 3, 2022 22:21

tmarkley mentioned this pull request Mar 14, 2022

[Tests] fix JUnit Reporter test #1338

Merged

7 tasks

tmarkley added the cve Security vulnerabilities detected by Dependabot or Mend label Mar 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades `jest` to v27 #1301

Upgrades `jest` to v27 #1301

tmarkley commented Mar 1, 2022 •

edited

tmarkley commented Mar 1, 2022

kavilla left a comment

tmarkley commented Mar 2, 2022 •

edited

kavilla Mar 2, 2022

ananzh Mar 2, 2022

tmarkley Mar 2, 2022

AMoo-Miki Mar 3, 2022

tmarkley Mar 3, 2022

kavilla Mar 3, 2022

tmarkley Mar 3, 2022

tmarkley Mar 3, 2022 •

edited

kavilla Mar 3, 2022

tmarkley Mar 3, 2022

kavilla left a comment

Upgrades jest to v27 #1301

Upgrades jest to v27 #1301

Conversation

tmarkley commented Mar 1, 2022 • edited

Description

Issues Resolved

Check List

tmarkley commented Mar 1, 2022

kavilla left a comment

Choose a reason for hiding this comment

tmarkley commented Mar 2, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmarkley Mar 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kavilla left a comment

Choose a reason for hiding this comment

Upgrades `jest` to v27 #1301

Upgrades `jest` to v27 #1301

tmarkley commented Mar 1, 2022 •

edited

tmarkley commented Mar 2, 2022 •

edited

tmarkley Mar 3, 2022 •

edited