Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) #4779

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 13, 2022

Description

See please GHSA-jjjh-jjxp-wpff (FasterXML/jackson-databind#3621)

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner October 13, 2022 18:55
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@owaiskazi19
Copy link
Member

@reta do we need to update the jackson dependencies for plugins as well?

@reta reta added Severity-Critical security Anything security related and removed Severity-Critical labels Oct 13, 2022
@reta
Copy link
Collaborator Author

reta commented Oct 13, 2022

@reta do we need to update the jackson dependencies for plugins as well?

@owaiskazi19 Sadly yes, if they use own Jackson Databind versions, I will take care of opensearch-java: https://github.com/opensearch-project/opensearch-java/blob/94eb0071d531050b6e96980551a8ea9938308030/java-client/build.gradle.kts#L136

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 2.1 backport 2.2 Backport to 2.2 branch backport 2.3 Backports to 2.3 branch backport 1.x backport 1.3 Backport to 1.3 branch labels Oct 13, 2022
@saratvemulapalli saratvemulapalli added >upgrade Label used when upgrading library dependencies (e.g., Lucene) dependencies Pull requests that update a dependency file v3.0.0 Issues and PRs related to version 3.0.0 labels Oct 13, 2022
@mch2
Copy link
Member

mch2 commented Oct 13, 2022

Is this version in central? I'm only seeing 2.13.4.1 - https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind. From what you linked it looks like that version still solves the CVE?

@reta
Copy link
Collaborator Author

reta commented Oct 13, 2022

Is this version in central? i'm only seeing 2.13.4.1.

It was released few hours ago :-) Should be in repo otherwise builds would fail

@reta
Copy link
Collaborator Author

reta commented Oct 13, 2022

Is this version in central? I'm only seeing 2.13.4.1 - https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind. From what you linked it looks like that version still solves the CVE?

See please: https://github.com/FasterXML/jackson-databind/releases/tag/jackson-databind-2.13.4.2
The 2.13.4.1 was unusable by Gradle because of: FasterXML/jackson-databind#3627

@reta reta merged commit 12f26d3 into opensearch-project:main Oct 13, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4779-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12f26d3d10c413aae6b1abffbe384169fcaea0f7
# Push it to GitHub
git push --set-upstream origin backport/backport-4779-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-4779-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4779-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12f26d3d10c413aae6b1abffbe384169fcaea0f7
# Push it to GitHub
git push --set-upstream origin backport/backport-4779-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4779-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-4779-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12f26d3d10c413aae6b1abffbe384169fcaea0f7
# Push it to GitHub
git push --set-upstream origin backport/backport-4779-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-4779-to-2.0.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-4779-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12f26d3d10c413aae6b1abffbe384169fcaea0f7
# Push it to GitHub
git push --set-upstream origin backport/backport-4779-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-4779-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-4779-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12f26d3d10c413aae6b1abffbe384169fcaea0f7
# Push it to GitHub
git push --set-upstream origin backport/backport-4779-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-4779-to-2.1.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-4779-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12f26d3d10c413aae6b1abffbe384169fcaea0f7
# Push it to GitHub
git push --set-upstream origin backport/backport-4779-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-4779-to-2.2.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-4779-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12f26d3d10c413aae6b1abffbe384169fcaea0f7
# Push it to GitHub
git push --set-upstream origin backport/backport-4779-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-4779-to-2.3.

@reta
Copy link
Collaborator Author

reta commented Oct 13, 2022

Ah ... obvously backports are failing, @saratvemulapalli @kotwanikunal I will address backports on Monday if you are OK with that guys, have to leave shorlty for a few days.

@kotwanikunal
Copy link
Member

Ah ... obvously backports are failing, @saratvemulapalli @kotwanikunal I will address backports on Monday if you are OK with that guys, have to leave shorlty for a few days.

I can pick a few. Let me help out with 1.x, 2.x, 2.3 to begin with.

kotwanikunal pushed a commit that referenced this pull request Oct 13, 2022
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)
kotwanikunal pushed a commit that referenced this pull request Oct 13, 2022
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)
@kotwanikunal
Copy link
Member

1.x: #4782
2.x: #4781

@kotwanikunal
Copy link
Member

@mch2 stepping in 🙂

mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Oct 13, 2022
…search-project#4779)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Oct 13, 2022
…search-project#4779)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Oct 13, 2022
…search-project#4779)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)
mch2 added a commit that referenced this pull request Oct 13, 2022
… (#4784)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
@mch2
Copy link
Member

mch2 commented Oct 13, 2022

2.3: #4784 - merged this already.
1.3: #4785

kotwanikunal added a commit that referenced this pull request Oct 14, 2022
… (#4782)

* Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) (#4779)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)

* Update changelog

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
mch2 added a commit that referenced this pull request Oct 14, 2022
… (#4785)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Collaborator Author

reta commented Oct 17, 2022

@kotwanikunal @mch2 thanks a mill guys for taking care of backports, really appreciate it 🙇

kotwanikunal added a commit that referenced this pull request Oct 17, 2022
… (#4781)

* Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) (#4779)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 12f26d3)

* Update changelog

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
…search-project#4779)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 2.1 backport 2.2 Backport to 2.2 branch backport 2.3 Backports to 2.3 branch dependencies Pull requests that update a dependency file security Anything security related >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants