Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Babel #1098

Closed
wants to merge 4 commits into from
Closed

Update Babel #1098

wants to merge 4 commits into from

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Oct 16, 2023

Description

Update Babel. This is mostly changes ripped from #770 to hopefully help with CVEs

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>
@@ -163,15 +152,13 @@
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"autoprefixer": "^9.8.6",
"babel-core": "7.0.0-bridge.0",
"babel-eslint": "^10.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't change this to @babel/eslint-parser because that package won't work with our version of ESLint

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
@BSFishy
Copy link
Contributor Author

BSFishy commented Oct 16, 2023

According to yarn audit, @babel/traverse CVEs are gone

@BSFishy
Copy link
Contributor Author

BSFishy commented Oct 17, 2023

react-view is causing Babel issues for reasons I don't understand. Closing this and attempting resolution of CVE

@BSFishy BSFishy closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant