Data Grid - Column Headers - Add tooltip on hover #809 #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: keskami <kkak808@gmail.com>
Signed-off-by: keskami <kkak808@gmail.com>
Signed-off-by: keskami <kkak808@gmail.com>
keskami
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: keskami <kkak808@gmail.com>
|
@keskami For UI changes like this can you provide some screencasts or screenshots of the before and after behavior of the component? That makes it much quicker for reviewers to understand your intended changes. |
|
ok! I'll make sure to do that from now on |
|
Before |
|
after |
|
Signed-off-by: Josh Romero <rmerqg@amazon.com>
BSFishy
reviewed
Dec 5, 2023
| setColumnWidth={setColumnWidth} | ||
| /> | ||
| ) : null} | ||
| <OuiToolTip position="top" content={id}> |
There was a problem hiding this comment.
I feel like a InnerText would be a better method to get the contents rather than just using id. Maybe we could otherwise use display || displayAsText || id if using 2 refs is too much of an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tooltip to DataGrid header cell
Issues Resolved
Fixes #809
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.