Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OuiPopover does not change position on the scroll (#1184) #1185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix OuiPopover does not change position on the scroll (#1184) #1185

wants to merge 1 commit into from

Conversation

gkottr
Copy link

@gkottr gkottr commented Dec 15, 2023 •
edited

Description

Fix OuiPopover does not change position on the scroll
(Set OuiPopover's scroll 3rd [add|remove]EventListener's argument to true)

Спаривание слонов – замечательный процесс (folk wisdom)

Issues Resolved

Fixes #1184

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fix OuiPopover does not change position on the scroll (opensearch-pro…
4c7aca2 
…ject#1184)

Signed-off-by: Vladimir Komolov <77komolovvladimir@gmail.com>
Signed-off-by: Комолов Владимир <VYuKomolov@sberbank.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@rednaksi91 rednaksi91 Awaiting requested review from rednaksi91 rednaksi91 is a code owner

@KrooshalUX KrooshalUX Awaiting requested review from KrooshalUX

@BSFishy BSFishy Awaiting requested review from BSFishy

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@andreymyssak andreymyssak Awaiting requested review from andreymyssak andreymyssak is a code owner

@SergeyMyssak SergeyMyssak Awaiting requested review from SergeyMyssak SergeyMyssak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
first-time-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] OuiPopover does not change position on the scroll
1 participant
@gkottr