Update node #767
Closed
Update node #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
…to Upgrade-webpack
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Jacques Metevier <jmetevier@gmail.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com> Fix tests Signed-off-by: Matt Provost <provomat@amazon.com> Revert Remove charts theme code Signed-off-by: Matt Provost <provomat@amazon.com> Update i18n tokens Signed-off-by: Matt Provost <provomat@amazon.com>
jmetev1
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc and
joshuarrrr
as code owners
|
I think it would be better for this if we wait until #765 is merged. We might get a little bit of messy git history if these two are competing. What you could do is clean out the changes to this PR, make the changes to |
|
i think this is junk. it was a follow up to my attempt to upgrade webpack. which i gave up on and someone else is working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update nvmrc node vs which is what github actions uses
Issues Resolved
#646
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.