Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💝 Kn Event buildflags patch #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cardil
Copy link
Member

@cardil cardil commented Oct 11, 2023

To avoid things like #281

/kind feature

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

@cardil: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

To avoid things like #281

/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from alanfx and matzew October 11, 2023 10:18
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil cardil added the enhancement New feature or request label Oct 11, 2023
@cardil
Copy link
Member Author

cardil commented Oct 11, 2023

/cc @dsimansk

@openshift-ci openshift-ci bot requested a review from dsimansk October 11, 2023 10:19
@dsimansk
Copy link

@cardil thanks! Can you check if it doesn't break release-next branch when event plugin is not present pls? I can probably try out tomorrow as well if you don't get to it.

@cardil
Copy link
Member Author

cardil commented Oct 11, 2023

@dsimansk: Can you check if it doesn't break release-next branch when event plugin is not present pls?

Oh, yeah. It will probably break it. However, maybe we can make the script optional. If kn-event isn't found in go.mod than skip the settings... Let me see

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold enhancement New feature or request
Projects
None yet
2 participants