Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use serverless-ci cluster pool #134

Merged
merged 6 commits into from Mar 21, 2024
Merged

Use serverless-ci cluster pool #134

merged 6 commits into from Mar 21, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Mar 19, 2024 •
edited

Depends on openshift/release#49904

Related to https://issues.redhat.com/browse/SRVCOM-3056

  • Bump OCP 4.14 to 4.15 as the PR above introduces a cluster pool for 4.15 that will be used
  • Run all tests for 4.15 (both periodic and pre-submit) on the existing cluster pool
  • Run tests for 4.14 and older by starting a new cluster from scratch, i.e. migrating off the openshift-ci cluster pool. Previously, tests for all versions were running on various cluster pools (4.12 - 4.14) owned by OpenShift team.
  • Tests on specific platforms (Azure, vSphere, Hypershift) will be staring clusters from scratch regardless of the OCP version because the existing cluster pool is a simple variant (IPI, AWS).

/hold

@openshift-ci openshift-ci bot requested review from ReToCode and rhuss March 19, 2024 10:54
@mgencur
Migrate off openshift-ci cluster pool
a8fa958 
* Only jobs requesting OCP 4.15 will use the existing cluster-pool
because its version is 4.15.
* Jobs that previously used openshift cluster-pools 4.14, 4.13, 4.12,
4.11 will now start clusters from scratch as there's no available
Serverless cluster pool for those versions.
@mgencur
Switch from 4.14 to 4.15
b63ee7b 
Make use of the new cluster pool for Serverless.
@mgencur mgencur mentioned this pull request Mar 20, 2024
Closed
@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

Testing the generated configurations in openshift/release#50032

@mgencur mgencur changed the title [WIP] Use serverless-ci cluster pool Use serverless-ci cluster pool Mar 20, 2024
ReToCode
ReToCode approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Mar 21, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 04b1504 into openshift-knative:main Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@ReToCode ReToCode

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgencur @ReToCode @openshift-merge-robot