[WIP] SRVCLI-401: 馃巵 Add kn-event configuration #154
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cardil
changed the title
cardil
changed the title
cardil
changed the title
|
@cardil: This pull request references SRVCLI-401 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/kind enhancement |
| repositories: | ||
| - org: openshift-knative | ||
| repo: kn-plugin-event | ||
| imagePrefix: client-plugin-event |
There was a problem hiding this comment.
It's a bit nit picking, but I wonder how the final names is generated from all those values. Is it going too verbose? I'd keep kn-plugin-event here. Wdyt?
There was a problem hiding this comment.
This is how they used to be called: https://github.com/openshift/release/blob/a45d8237303d117149c08a5c4c56a558fd62dfbf/ci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next__415.yaml#L74-L79
However, I don't know if I'll be able to keep the current naming, and will be force to adjust kn-event to follow hack's machinery.
This is what I am currently getting (WIP):
test:
- as: test
+ cli: latest
commands: openshift/e2e-tests.sh
dependencies:
- - env: TEST_IMAGES_EVENTSHUB
+ - env: CLIENT_PLUGIN_EVENT_BUILD_IMAGE
+ name: client-plugin-event-build-image
+ - env: CLIENT_PLUGIN_EVENT_SENDER
+ name: client-plugin-event-sender
+ - env: CLIENT_PLUGIN_EVENT_SOURCE_IMAGE
+ name: client-plugin-event-source-image
+ - env: CLIENT_PLUGIN_EVENT_TEST_EVENTSHUB
name: client-plugin-event-test-eventshub
- - env: TEST_IMAGES_WATHOLA_FORWARDER
+ - env: CLIENT_PLUGIN_EVENT_TEST_WATHOLA_FORWARDER
name: client-plugin-event-test-wathola-forwarder
- - env: IMAGES_KN_EVENT_SENDER
- name: client-plugin-event-sender
- from: src
+ from: client-plugin-event-source-image
resources:
requests:
cpu: 100m
timeout: 30m0sThere was a problem hiding this comment.
Here's a full diff, if you're interested: https://gist.github.com/cardil/adedaf1313446a6329fb9a958670198a
| binaryBuildCommands: |- | ||
| export HOME=/tmp | ||
| export TEST_IMAGES_DIR=/usr/bin | ||
| ./mage build |
There was a problem hiding this comment.
In case of client, I've been looking at this stanza and my thought's been to wrap it into Dockerfile stage build to simplify CI config. Similarly to Makefile PR in the kn-plugin-event midstream, but also execute the make withing Docker builds.
There was a problem hiding this comment.
This is how Openshift CI advises building binaries in a separate step, and later use the bin image contents, while building the images.
Since then, most Serverless repos moved to pure Docker approach, when the bin building doesn't matter, as everything is done in the build image step: https://github.com/openshift-knative/serving/blob/release-next/openshift/ci-operator/knative-images/activator/Dockerfile
IDK, if I keep kn-event current setup or shift it to how other repos does this. I'm leaning towards the pure Dockerfile approach.
| env: | ||
| SKIP_MESH_AUTH_POLICY_GENERATION: "true" |
There was a problem hiding this comment.
Is it related to work on event plugin? Would it make more sense to check in S-O Makefile if PROW and based on that define defaults skips? Maybe we will need more skips in the future.
There was a problem hiding this comment.
| generate-ci-no-clean: generate-eventing-ci generate-serving-ci generate-serverless-operator-ci | ||
| .PHONY: generate-ci-no-clean | ||
|
|
||
| generate-eventing-ci: |
There was a problem hiding this comment.
These cmd name changes will most likely break GitHub actions that execute generators periodically.
There was a problem hiding this comment.
I'll update the workflows in this repo. Are you aware of other cross-repo references to those targets?
|
@cardil: This pull request references SRVCLI-401 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Changes
Fixes SRVCLI-401
Here's the current config diff for kn-event: https://gist.github.com/cardil/adedaf1313446a6329fb9a958670198a (I'll keep it updated)