Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRVCLI-401: 💝 Donate deviate tool #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cardil
Copy link
Member

@cardil cardil commented May 10, 2024

Donating the deviate tool from https://github.com/cardil/deviate

Related to SRVCLI-401

@cardil
Copy link
Member Author

cardil commented May 10, 2024

/kind enhancement

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label May 10, 2024
Copy link

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign retocode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil cardil force-pushed the feature/donate-deviate-tool branch from d1cae9f to a98c88c Compare May 10, 2024 11:16
@cardil cardil changed the title 💝 Donate deviate tool SRVCLI-401: 💝 Donate deviate tool May 10, 2024
@openshift-ci-robot
Copy link

@cardil: This pull request references SRVCLI-401 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Donating the deviate tool from https://github.com/cardil/deviate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@cardil: This pull request references SRVCLI-401 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Donating the deviate tool from https://github.com/cardil/deviate

Related to SRVCLI-401

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cardil cardil marked this pull request as ready for review May 10, 2024 11:20
@openshift-ci openshift-ci bot requested review from aliok and matzew May 10, 2024 11:20
@cardil
Copy link
Member Author

cardil commented May 10, 2024

/cc @pierDipi
/cc @creydr
/cc @ReToCode

@dsimansk
Copy link

Would it make sense to make it a submodule isolate related go.mod changes?

@cardil
Copy link
Member Author

cardil commented May 16, 2024

@dsimansk: Would it make sense to make it a submodule isolate related go.mod changes?

Yes, I was thinking the same. My initial idea was to change the repo's layout to mirror the https://github.com/knative/toolbox (and rename the repo as well). But, the team was reluctant to rename because of short terms breakages. The same applies to any re-layout. Personally, I would go for it, as the breakages aren't a big problem here, and could be quickly fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants