Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Update cloudevents/sdk-go/v2 to latest release #380

Conversation

dsimansk
Copy link

@dsimansk dsimansk commented Mar 7, 2024

Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cardil
Copy link
Member

cardil commented Mar 7, 2024

/hold

@cardil
Copy link
Member

cardil commented Mar 7, 2024

/lgtm-cancel

The multierr dependency requires Go 1.19

@openshift-ci openshift-ci bot removed the lgtm label Mar 7, 2024
Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold-cancel

@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2024
Copy link

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Member

cardil commented Mar 7, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 9b3656d into openshift-knative:release-1.11 Mar 7, 2024
3 checks passed
@dsimansk dsimansk deleted the pr/release-v1.11-ce-bump branch March 7, 2024 14:49
@mgencur
Copy link

mgencur commented Mar 11, 2024

@dsimansk @cardil Hey, what about newer branches? release-1.12 and release-1.13 still have this:

github.com/cloudevents/sdk-go/v2 v2.13.0

Perhaps we should fix it for future releases and cherry-pick this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants