馃Ч Switch to Node 20 LTS #2557
馃Ч Switch to Node 20 LTS #2557
Conversation
cardil
force-pushed
the
chore/node-20
branch
2 times, most recently
from
0c9a194
to
2a59426
Compare
|
/kind cleanup |
|
@cardil: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@matejvasek where do we generally stand w/ Node 20 ? |
|
see also -> https://github.com/knative/func/pull/2094/files |
At serverless-operator we just use node for testing. I think it makes 100% sense to follow the current supported Node version from func. |
|
It turned out that the setup here, after we switched to RHEL8 as base for build image, was invalid: Maybe we should switch to RHEL9, like what @mgencur is doing with openshift-knative/serving#650. Also, the OCP is using the RHEL9 for a while now. Then, we can do Something else isn't clear to me. I'm changing the Dockerfiles in this PR. But it seems the originals are being used for the CI, not the ones in this PR, see the build-log. But, our |
We use RHEL8 because it's closer to what what is productized in the end. There we use RHEL8. But I think it would also work if we switched to RHEL9 base image in CI. I don't see a big problem with that.
Your changes will be used only after-merge. This is for security reasons - one should not be able to change the build process just by sending a PR. At least that's what I was told a few years back. |
Makes sense. But, that means there is no way to test the changes before the merge? |
You can possibly create your own fork, create CI setup for it, and then send a PR for openshift/release targeting your fork. Some "formal" checks on the PR will fail but it will be possible to run "rehearsal" jobs. |
Yes, but this is my point. To switch the base to RHEL 9 everywhere: in CI, testing, and productization. As I said. The OCP is being based on RHEL 9 for a couple of releases now, see: https://docs.openshift.com/container-platform/4.13/release_notes/ocp-4-13-release-notes.html#ocp-4-13-about-this-release |
That can be done in one PR? The "create CI setup for it, and then send a PR for openshift/release targeting your fork"? If so, this is the same security thread, as running Dockerfiles from a PR. Most CI's allow to run a modified CI configuration, if it was posted by an approved contributor. Here it is even stranger, as the OpenShift CI/Prow supports the |
I did it this way in the past - create my fork, include the required changes already on the given branch, and then send an "empty" PR against openshift/release against my fork to run rehearsal jobs. For the other concerns, please talk to DPTP. |
|
@mgencur I did the exact test you proposed. Here you can see the successful job: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/49784/rehearse-49784-periodic-ci-cardil-serverless-operator-node20-main-414-ui-e2e-aws-414-c/1767657276690141184 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cardil: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test 414-test-upgrade-aws-414 Looks like infra to me. Either way. This isn't connected. |
openshift-merge-bot
bot
merged commit 680bf7b
into
openshift-knative:main
|
/cherry-pick release-1.32 |
|
@cardil: new pull request created: #2564 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proposed Changes