Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Bump Serverless Operator version after release-1.33 cut #2636

Merged
merged 2 commits into from May 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2024

Bump SO version + run make generated-files

Copy link
Contributor

openshift-ci bot commented May 8, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member

creydr commented May 8, 2024

/ok-to-test

@creydr
Copy link
Member

creydr commented May 8, 2024

render reference "registry.ci.openshift.org/knative/release-1.33.0:serverless-bundle": error resolving name for image ref registry.ci.openshift.org/knative/release-1.33.0:serverless-bundle: registry.ci.openshift.org/knative/release-1.33.0:serverless-bundle: not found

I think we need #2637 in first

@pierDipi
Copy link
Member

pierDipi commented May 9, 2024

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@pierDipi
Copy link
Member

pierDipi commented May 9, 2024

There is a problem, promotion tag is release-1.33 but it needs to be release-1.33.0, I'm adding a fix that will also support any patch version for future patch version bumps

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7d60f86 and 2 for PR HEAD abcaf61 in total

@pierDipi
Copy link
Member

pierDipi commented May 9, 2024

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2cc132d and 1 for PR HEAD abcaf61 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3bafe80 and 0 for PR HEAD abcaf61 in total

@creydr
Copy link
Member

creydr commented May 10, 2024

@openshift-ci-robot
Copy link

/hold

Revision abcaf61 was retested 3 times: holding

@creydr
Copy link
Member

creydr commented May 10, 2024

/test 415-images

@pierDipi
Copy link
Member

/retest

1 similar comment
@pierDipi
Copy link
Member

/retest

@pierDipi
Copy link
Member

I can download the image but for some reason it's saying "not found"

@creydr
Copy link
Member

creydr commented May 10, 2024

/test 415-images

@creydr
Copy link
Member

creydr commented May 10, 2024

I can download the image but for some reason it's saying "not found"

ci/prow/415-images — Job succeeded.
maybe this was a caching issue 🤷

/retest

@creydr
Copy link
Member

creydr commented May 10, 2024

/test 415-test-upgrade-aws-415

@openshift-ci openshift-ci bot removed the lgtm label May 13, 2024
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, github-actions[bot], pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 09ea7e4 into main May 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants