Incorporate upstream encryption changes to Serving #702
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 415-test-e2e-tls-aws-415 |
/test 415-test-e2e-tls-aws-415 |
/test 415-test-e2e-tls-aws-415 |
| export CA_CERT=ca-cert | ||
| # This needs to match $san from test/config/tls/generate.sh | ||
| export SERVER_NAME=knative.dev | ||
| fi | ||
| } | ||
|
|
||
| function run_e2e_tests(){ |
There was a problem hiding this comment.
Curious if you want to enable tests from ./test/e2e/systeminternaltls or what's the plan for those tests? I want to add the test for certificate rotation there.
There was a problem hiding this comment.
Good idea, I'll take a look.
There was a problem hiding this comment.
Let's see if that works out. We'll need patches for the tests, as OCP is a bit different. But we need to wait for knative#15217, otherwise we'll have to do it twice.
| @@ -129,8 +129,9 @@ func TestClusterLocalDomainTLSClusterExternalVisibility(t *testing.T) { | |||
| t.Fatalf("Internal URL scheme of service %v was not https", names.Service) | |||
| } | |||
|
|
|||
| if externalURL.Scheme != "http" { | |||
| t.Fatalf("External URL scheme of service %v was not http", names.Service) | |||
| // On OpenShift this is always https | |||
There was a problem hiding this comment.
will need patches in main as well
| @@ -93,7 +93,9 @@ func TestSystemInternalTLS(t *testing.T) { | |||
| } | |||
| activatorPod := pods.Items[0] | |||
|
|
|||
| req := clients.KubeClient.CoreV1().Pods(activatorPod.Namespace).GetLogs(activatorPod.Name, &corev1.PodLogOptions{}) | |||
| req := clients.KubeClient.CoreV1().Pods(activatorPod.Namespace).GetLogs(activatorPod.Name, &corev1.PodLogOptions{ | |||
There was a problem hiding this comment.
will need patches in main as well
ReToCode
changed the title
|
@ReToCode: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes JIRA https://issues.redhat.com/browse/SRVKS-1198
Changes
ENABLE_INTERNAL_TLS->ENABLE_TLScluster-local-domain-tlsandsystem-internal-tlsclusterlocaldomaintlsandsysteminternaltlsPatches will be ported to main on a separate PR.