[release-v1.14] Tests for multi-container readiness and liveness probes #715
Conversation
* Tests for multi-container readiness and liveness probes * Use PORT instead of HEALTHCHECK_PORT for serving container * Fixes * Pass FORWARD_PORT in service_test * Revert readiness image to only fail readiness probe handleMain does not reflect the readiness state like it was before * Use proxy to start failing sidecar This reverts commit c6929e6e0e1190b15c990c7873b269abdae9609d. * Test liveness failure * Use /healthz/readiness in multicontainer test * Address review feedback * start package-private functions with lowercase * use already existing const for "user-container" * rename getPort to getServerPort to make it more specific (avoid confusion with FORWARD_PORT) * Fix lint
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
TLS tests for 1.14 are WIP, you can ignore those. |
mgencur
merged commit 0a65b04
into
openshift-knative:release-v1.14
This is an automated cherry-pick of #710
/assign mgencur