-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-31727: Invalid Pull-Secret when using password which contains a colon character #6258
OCPBUGS-31727: Invalid Pull-Secret when using password which contains a colon character #6258
Conversation
Skipping CI for Draft Pull Request. |
@pastequo: This pull request references Jira Issue OCPBUGS-33243, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@pastequo: This pull request references Jira Issue OCPBUGS-33243, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
957b91a
to
618d137
Compare
/jira refresh |
@pastequo: This pull request references Jira Issue OCPBUGS-33243, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6258 +/- ##
==========================================
- Coverage 68.27% 68.16% -0.11%
==========================================
Files 241 244 +3
Lines 35873 37903 +2030
==========================================
+ Hits 24493 25838 +1345
- Misses 9215 9770 +555
- Partials 2165 2295 +130
|
@pastequo: This pull request references Jira Issue OCPBUGS-31727, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
… a colon character Fix the validation rule while parsing pull secret. Fix some typos in test file.
618d137
to
9961cf5
Compare
/jira refresh |
@pastequo: This pull request references Jira Issue OCPBUGS-31727, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (lalon@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
/test e2e-agent-compact-ipv4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing the typos!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, pastequo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.16 release-4.15 |
@pastequo: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@pastequo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@pastequo: Jira Issue OCPBUGS-31727: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31727 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@pastequo: new pull request created: #6362 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix the validation rule while parsing pull secret. Fix some typos in test file.
An unit test had been updated to test a problematic input
Will be tested next week
Should be backported in openshift 4.15 & 4.16
List all the issues related to this PR
What environments does this code impact?
I guess
How was this code tested?
Started locally assisted-service with podman. Issue was reproduced & fixed with the changes.
However I didn't check if the installation could go until the end with a password containing a ':'
Seems to be a legit char tho.
Checklist
docs
, README, etc)Reviewers Checklist