-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-909: Restructure gencrypto package #6272
AGENT-909: Restructure gencrypto package #6272
Conversation
@pawanpinjarkar: This pull request references AGENT-909 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @carbonin |
5b036d1
to
688f2a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6272 +/- ##
==========================================
- Coverage 68.28% 68.27% -0.02%
==========================================
Files 241 241
Lines 35855 35855
==========================================
- Hits 24484 24479 -5
- Misses 9211 9213 +2
- Partials 2160 2163 +3
|
2ce5a52
to
be09343
Compare
be09343
to
752c749
Compare
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Moving the code in |
@carbonin As continue of our talk, I think it would be best placing this pkg in a separate repository inside |
Yes, I think breaking it out into its own repo would be best so we don't have to deal with more local modules and so that it can be easily shared with the installer folks. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@carbonin I have created - https://issues.redhat.com/browse/MGMT-17779 to address this |
The agent installer is implementing a new auth type and could reuse the existing functionality of generating the public/private keys and JWT tokens. This change restructures the existing code for agent installer to be able to import it.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist