MGMT-17770: Split ignition handling file #6283
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@carbonin: This pull request references MGMT-17770 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XXL
openshift-ci
bot
added
the
approved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6283 +/- ##
==========================================
+ Coverage 68.25% 68.37% +0.11%
==========================================
Files 242 244 +2
Lines 35902 35996 +94
==========================================
+ Hits 24506 24611 +105
+ Misses 9229 9218 -11
Partials 2167 2167
|
carbonin
force-pushed
the
split-ignition-handling
branch
from
1959d36
to
c013620
Compare
openshift-merge-robot
added
the
needs-rebase
carbonin
force-pushed
the
split-ignition-handling
branch
from
d6519d5
to
99c49d5
Compare
openshift-merge-robot
removed
the
needs-rebase
carbonin
force-pushed
the
split-ignition-handling
branch
from
99c49d5
to
cc4ecc5
Compare
|
/retest-required |
|
/retest-required |
|
/test edge-e2e-metal-assisted |
|
/test e2e-agent-compact-ipv4 |
openshift-merge-robot
added
the
needs-rebase
Previously ignition.go contained code for general ignition parsing, code for generating install manifests using opesnshift-install, and code for creating the discovery ignition. The discovery ignition and installer manifests code has mostly nothing to do with each other so those should be separated out into their own files. ignition.go remains as a place for ignition parsing code as well as the very small number of common functions between the installer manifests and discovery ignition use cases.
It isn't used anywhere
This also makes some small improvements like moving some test globals (like workDir, and cluster) into the per-test lifecyle which makes them easier to track and manage if and when individual tests need them to change.
carbonin
force-pushed
the
split-ignition-handling
branch
from
cc4ecc5
to
859bb96
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/test edge-subsystem-kubeapi-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@carbonin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR splits the mostly unrelated logic in
ignition/ignition.gointo three files.ignition/discovery.go: discovery ignition builder and helpersignition/installmanifests.go: runs installer binary to create host ignition files and cluster manifestsignition/ignition.go: ignition parsing and a single common helper functionList all the issues related to this PR
https://issues.redhat.com/browse/MGMT-17770
What environments does this code impact?
How was this code tested?
It's a refactoring so unit tests and CI tests passing should be sufficient
Checklist
docs, README, etc)Reviewers Checklist