Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update push steps to use containerized skopeo #343

Merged
merged 2 commits into from Apr 1, 2024

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Mar 29, 2024

Currently, we're depending on the version of skopeo installed on a Jenkins VM, which has gone out of date. Yes, the VM should be updated, but this gives us more control over the version of skopeo being used in CI.

OSD-21843

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
Signed-off-by: Michael Shen <mshen@redhat.com>
@2uasimojo
Copy link
Member

Unrelated to this PR, this is biting ya :(

Suggest nailing that down to a specific version. Not sure why we decided not to do that originally.

@mjlshen
Copy link
Contributor Author

mjlshen commented Mar 30, 2024

Caused by kubernetes-sigs/controller-runtime#2744

@mjlshen mjlshen force-pushed the OSD-21843 branch 2 times, most recently from 55d9c4a to f49ffaa Compare April 1, 2024 13:02
Signed-off-by: Michael Shen <mshen@redhat.com>
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tonytheleg
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, tonytheleg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 879ef19 into openshift:master Apr 1, 2024
3 checks passed
@mjlshen mjlshen deleted the OSD-21843 branch April 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants