Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-180: Rebase 1.11.5 #142

Merged
merged 6 commits into from Oct 10, 2023

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Sep 14, 2023

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
* make update
* make bundle

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh swghosh changed the title Rebase 1.11.5 CM-180: Rebase 1.11.5 Sep 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor
  • push commit b1d501c85d97afd2adde2e86c2b119ac060caece to openshift/jetstack-cert-manager release-1.11 branch
  • openshift/release CI update related PRs
    • operand image mirroring with new tag
    • ci pipeline use updated operand image tags

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thejasn
Copy link
Contributor

thejasn commented Sep 18, 2023

LGTM

can you also update the version on the readme?

@thejasn
Copy link
Contributor

thejasn commented Sep 18, 2023

Also can you also add the upgrade graph preview post release of 1.11.5 and 1.12.0?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Sep 18, 2023

Below is an upgrade graph including:

base with index 1.11.4 release
+ v1.12.0 version of operator
+ this z-stream version of operator, v1.11.5

Note: both v1.12.0 and v1.11.5 are marked to replace v1.11.4 which has the only side effect that stable-v1 channel will not get this new z-stream v1.11.5 version with our current plan. I don't oversee any other adverse effects aside of that so far.

graph LR
  %% package "cert-manager-operator"
  subgraph "cert-manager-operator"
    %% channel "stable-v1"
    subgraph cert-manager-operator-stable-v1["stable-v1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]-- "skipRange(<1.10.3)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- replaces --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- "skipRange(>=1.11.4 <1.12.1)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
    end
    %% channel "stable-v1.10"
    subgraph cert-manager-operator-stable-v1.10["stable-v1.10"]
      cert-manager-operator-stable-v1.10-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
    end
    %% channel "stable-v1.11"
    subgraph cert-manager-operator-stable-v1.11["stable-v1.11"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]-- "skipRange(<1.10.3)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.5["cert-manager-operator.v1.11.5"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.5["cert-manager-operator.v1.11.5"]-- replaces --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.5["cert-manager-operator.v1.11.5"]-- "skipRange(>=1.11.4 <1.11.5)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
    end
    %% channel "stable-v1.12"
    subgraph cert-manager-operator-stable-v1.12["stable-v1.12"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]-- "skipRange(<1.10.3)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- replaces --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- "skipRange(>=1.11.4 <1.12.1)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
    end
  end

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@thejasn
Copy link
Contributor

thejasn commented Sep 18, 2023

Below is an upgrade graph including:

base with index 1.11.4 release
+ v1.12.0 version of operator
+ this z-stream version of operator, v1.11.5

Note: both v1.12.0 and v1.11.5 are marked to replace v1.11.4 which has the only side effect that stable-v1 channel will not get this new z-stream v1.11.5 version with our current plan. I don't oversee any other adverse effects aside of that so far.

graph LR
  %% package "cert-manager-operator"
  subgraph "cert-manager-operator"
    %% channel "stable-v1"
    subgraph cert-manager-operator-stable-v1["stable-v1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]-- "skipRange(<1.10.3)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- replaces --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- "skipRange(>=1.11.4 <1.12.1)" --> cert-manager-operator-stable-v1-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
    end
    %% channel "stable-v1.10"
    subgraph cert-manager-operator-stable-v1.10["stable-v1.10"]
      cert-manager-operator-stable-v1.10-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
    end
    %% channel "stable-v1.11"
    subgraph cert-manager-operator-stable-v1.11["stable-v1.11"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]-- "skipRange(<1.10.3)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.5["cert-manager-operator.v1.11.5"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.5["cert-manager-operator.v1.11.5"]-- replaces --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.5["cert-manager-operator.v1.11.5"]-- "skipRange(>=1.11.4 <1.11.5)" --> cert-manager-operator-stable-v1.11-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
    end
    %% channel "stable-v1.12"
    subgraph cert-manager-operator-stable-v1.12["stable-v1.12"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]-- "skipRange(<1.10.3)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]-- "skipRange(<1.11.1)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- skips --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.2["cert-manager-operator.v1.10.2"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.10.3["cert-manager-operator.v1.10.3"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]-- "skipRange(<1.11.4)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.1["cert-manager-operator.v1.11.1"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- replaces --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
      cert-manager-operator-stable-v1.12-cert-manager-operator.v1.12.0["cert-manager-operator.v1.12.0"]-- "skipRange(>=1.11.4 <1.12.1)" --> cert-manager-operator-stable-v1.12-cert-manager-operator.v1.11.4["cert-manager-operator.v1.11.4"]
    end
  end

Hmm, in that case can you verify if 1.11.5 changes(commits) has been cherry picked onto 1.12.4 upstream?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Sep 18, 2023

release-1.12: cert-manager/cert-manager#6318 -- this is a golang bump to 1.20.7 to fix the crypto security issue
release-1.11: cert-manager/cert-manager#6317 -- this is a golang bump to 1.19.9 to fix " "

Hmm, in that case can you verify if 1.11.5 changes(commits) has been cherry picked onto 1.12.4 upstream?

Though it's not a direct cherry-pick as it is golang minor version bump, I would say they look all good upstream, the CVE should be fixed in both 1.11 and 1.12 now.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Sep 21, 2023

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 21, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Sep 25, 2023

/test e2e-operator

@thejasn
Copy link
Contributor

thejasn commented Oct 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Oct 10, 2023

Self-adding doc label as in CM-180 JIRA issue, I've added doc-needed label.
/label docs-approved

@snarayan-redhat we would need only release note doc updates for cert-manager 1.11.5 z-stream.

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Oct 10, 2023
@swghosh
Copy link
Member Author

swghosh commented Oct 10, 2023

/cc @lunarwhite @xingxingxia
for qe-approved label
/cc @davemulford
for px-approved label

Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2023

@swghosh: This pull request references CM-180 which is a valid jira issue.

In response to this:

[v1.11.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@b1d501c85d97afd2adde2e86c2b119ac060caece # v1.11.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.11.4)

v1.11.5

Important security fix that addresses CVE-2023-29409.

Others: cert-manager/cert-manager#6317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Oct 10, 2023

/label px-approved
(this is a z-stream rebase which shouldn't need any product lifecycle changes)

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 13c8476 into openshift:cert-manager-1.11 Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants