OCPBUGS-23999: Set owner for default ingress configmap #1000

vrutkovs · 2023-11-21T10:31:05Z

This adds annotation which identifies the component used to file issues with this certificate. The annotation is verified by the test, so that all certificates would be registered and have owners assigned. More metadata would be added later.

See openshift/enhancements#1502 for proposed workflow with TLS registry

openshift-ci · 2023-11-21T10:31:12Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

vrutkovs · 2023-11-22T07:50:03Z

/test e2e-aws-ovn

vrutkovs · 2023-11-22T09:15:18Z

/test e2e-aws-ovn

vrutkovs · 2023-11-22T11:07:51Z

/test e2e-aws-ovn

Miciah · 2023-11-27T23:29:29Z

@vrutkovs, this PR needs to be rebased since #990 merged. Also, the PR needs a Jira issue. Do you intend to get this change in OpenShift 4.15?

Miciah · 2023-11-27T23:31:56Z

pkg/operator/controller/certificate-publisher/publish_ca.go

+			Annotations: map[string]string{
+				annotations.OpenShiftComponent: "Networking / router",
+			},


You'll need to update updateRouterCAConfigMap and deleteRouterCAConfigMap if you want the operator to add this annotation on upgrade.

Updated routerCAConfigMapsEqual to return false when annotations are not set or do not match the desired. This will trigger Update call in updateRouterCAConfigMap

Miciah · 2023-11-27T23:33:08Z

pkg/operator/controller/certificate/ca.go

+			Annotations: map[string]string{
+				annotations.OpenShiftComponent: "Networking / router",
+			},


You'll need to add update logic to ensureRouterCASecret if you want the operator to add this annotation on upgrade.

I don't think its required, if !reflect.DeepEqual in ensureRouterCASecret would start an update if annotations mismatch

openshift-ci-robot · 2023-11-28T10:17:51Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-23999, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This adds annotation which identifies the component used to file issues with this certificate. The annotation is verified by the test, so that all certificates would be registered and have owners assigned. More metadata would be added later.

See openshift/enhancements#1502 for proposed workflow with TLS registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2023-11-28T11:50:20Z

cc @melvinjoseph86

vrutkovs · 2023-11-29T11:02:24Z

/test e2e-gcp-operator

candita · 2023-11-29T20:39:24Z

Since you've started this...
/assign @Miciah

melvinjoseph86 · 2023-12-01T17:20:21Z

melvinjoseph@mjoseph-mac Downloads % oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.15.0-0.ci.test-2023-12-01-120802-ci-ln-9rgxv9b-latest True False 89m Cluster version is 4.15.0-0.ci.test-2023-12-01-120802-ci-ln-9rgxv9b-latest

melvinjoseph@mjoseph-mac Downloads % oc get secret -n openshift-ingress-operator router-ca -o yaml | yq -y '.metadata.annotations'
openshift.io/owning-component: Networking / router

Marking this bug as verified using pre-image verification process

melvinjoseph86 · 2023-12-01T17:20:43Z

/label qe-approved

openshift-ci-robot · 2023-12-01T17:20:49Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-23999, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

This adds annotation which identifies the component used to file issues with this certificate. The annotation is verified by the test, so that all certificates would be registered and have owners assigned. More metadata would be added later.

See openshift/enhancements#1502 for proposed workflow with TLS registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

melvinjoseph86 · 2023-12-04T09:26:07Z

/test e2e-gcp-operator

melvinjoseph86 · 2023-12-13T10:39:18Z

/retest-required

openshift-bot · 2024-03-13T01:00:49Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2024-04-12T08:30:49Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

Miciah · 2024-04-12T18:48:44Z

/remove-lifecycle rotten

candita · 2024-05-15T15:27:09Z

@vrutkovs should we close this one, or will you pursue the changes that Miciah mentioned?

openshift-ci · 2024-05-16T06:45:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from miciah. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrutkovs · 2024-05-16T10:10:47Z

Verified that annotations are being set on clean install and in the upgrade job:

"metadata": {
                "annotations": {
                    "openshift.io/owning-component": "Networking / router"
                },
                "creationTimestamp": "2024-05-16T07:07:04Z",
                "name": "default-ingress-cert",
                "namespace": "openshift-config-managed",
                "resourceVersion": "7828",
                "uid": "04ae0ff8-064a-43fd-9ebf-012b8c3f093f"
            }

gcs278 · 2024-05-16T18:32:44Z

FYI: Need #1054 to fixed operator E2E which is permafailing.

vrutkovs · 2024-05-17T10:39:57Z

/retest

openshift-ci · 2024-05-17T12:50:28Z

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023

vrutkovs force-pushed the annotate-owners branch from 3e141bd to f8db41b Compare November 22, 2023 11:07

vrutkovs marked this pull request as ready for review November 23, 2023 14:59

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2023

openshift-ci bot requested review from alebedev87 and Miciah November 23, 2023 15:00

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2023

Miciah reviewed Nov 27, 2023

View reviewed changes

vrutkovs force-pushed the annotate-owners branch from f8db41b to 41c7d08 Compare November 28, 2023 09:40

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023

vrutkovs changed the title ~~Set owner for default ingress configmap~~ OCPBUGS-23999: Set owner for default ingress configmap Nov 28, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 28, 2023

openshift-ci bot requested a review from lihongan November 28, 2023 10:17

openshift-ci bot assigned Miciah Nov 29, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 1, 2023

openshift-ci bot requested a review from melvinjoseph86 December 1, 2023 17:20

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2024

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 12, 2024

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 12, 2024

vrutkovs force-pushed the annotate-owners branch from 41c7d08 to 49a1ed1 Compare May 16, 2024 06:44

vrutkovs added 2 commits May 16, 2024 08:45

Set owner for default ingress configmap

844b9b5

Set owner for default router CA

bdf635b

vrutkovs force-pushed the annotate-owners branch from 49a1ed1 to bdf635b Compare May 16, 2024 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-23999: Set owner for default ingress configmap #1000

OCPBUGS-23999: Set owner for default ingress configmap #1000

vrutkovs commented Nov 21, 2023 •

edited

openshift-ci bot commented Nov 21, 2023

vrutkovs commented Nov 22, 2023

vrutkovs commented Nov 22, 2023

vrutkovs commented Nov 22, 2023

Miciah commented Nov 27, 2023

Miciah Nov 27, 2023

vrutkovs May 16, 2024

Miciah Nov 27, 2023

vrutkovs May 16, 2024

openshift-ci-robot commented Nov 28, 2023

lihongan commented Nov 28, 2023

vrutkovs commented Nov 29, 2023

candita commented Nov 29, 2023

melvinjoseph86 commented Dec 1, 2023

melvinjoseph86 commented Dec 1, 2023

openshift-ci-robot commented Dec 1, 2023

melvinjoseph86 commented Dec 4, 2023

melvinjoseph86 commented Dec 13, 2023

openshift-bot commented Mar 13, 2024

openshift-bot commented Apr 12, 2024

Miciah commented Apr 12, 2024

candita commented May 15, 2024

openshift-ci bot commented May 16, 2024

vrutkovs commented May 16, 2024

gcs278 commented May 16, 2024

vrutkovs commented May 17, 2024

openshift-ci bot commented May 17, 2024

OCPBUGS-23999: Set owner for default ingress configmap #1000

Are you sure you want to change the base?

OCPBUGS-23999: Set owner for default ingress configmap #1000

Conversation

vrutkovs commented Nov 21, 2023 • edited

openshift-ci bot commented Nov 21, 2023

vrutkovs commented Nov 22, 2023

vrutkovs commented Nov 22, 2023

vrutkovs commented Nov 22, 2023

Miciah commented Nov 27, 2023

Miciah Nov 27, 2023

Choose a reason for hiding this comment

vrutkovs May 16, 2024

Choose a reason for hiding this comment

Miciah Nov 27, 2023

Choose a reason for hiding this comment

vrutkovs May 16, 2024

Choose a reason for hiding this comment

openshift-ci-robot commented Nov 28, 2023

lihongan commented Nov 28, 2023

vrutkovs commented Nov 29, 2023

candita commented Nov 29, 2023

melvinjoseph86 commented Dec 1, 2023

melvinjoseph86 commented Dec 1, 2023

openshift-ci-robot commented Dec 1, 2023

melvinjoseph86 commented Dec 4, 2023

melvinjoseph86 commented Dec 13, 2023

openshift-bot commented Mar 13, 2024

openshift-bot commented Apr 12, 2024

Miciah commented Apr 12, 2024

candita commented May 15, 2024

openshift-ci bot commented May 16, 2024

vrutkovs commented May 16, 2024

gcs278 commented May 16, 2024

vrutkovs commented May 17, 2024

openshift-ci bot commented May 17, 2024

vrutkovs commented Nov 21, 2023 •

edited