NE-1400: Bump to OSSM 2.5 and Gateway API v0.6.2 CRDs #1018

candita · 2024-01-24T20:18:45Z

OSSM 2.5 supports Istio 1.18 and therefore only Gateway API v0.6.2 CRDS.

Pull the new CRD yaml from upstream and update pkg/manifests/assets/gateway-api
Update the pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go to reflect changes required by OSSM 2.5.

openshift-ci-robot · 2024-01-24T20:18:49Z

@candita: This pull request references NE-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSSM 2.5 currently not working with latest Gateway API objects. Verify whether the old objects still work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

candita · 2024-02-27T20:41:42Z

NAME TestAll/parallel/TestRouteMetricsControllerOnlyRouteSelector
route_metrics_test.go:386: failed to update route: Operation cannot be fulfilled on routes.route.openshift.io "route-rs-foo-label": the object has been modified; please apply your changes to the latest version and try again
NAME TestAll/parallel/TestRouteMetricsControllerOnlyRouteSelector
panic.go:522: deleted ingresscontroller ic-rs-metrics-test

/test e2e-azure-operator

candita · 2024-02-27T20:42:53Z

Installation failure on an optional test
/test e2e-aws-ovn-single-node

openshift-ci-robot · 2024-03-20T20:37:39Z

@candita: This pull request references NE-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSSM 2.5 supports Istio 1.18 and therefore only Gateway API v0.6.2 CRDS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Miciah · 2024-04-10T15:13:56Z

pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go

+		// Istio will only create the default gateway class if this is true.
+		"PILOT_ENABLE_GATEWAY_API_GATEWAYCLASS_CONTROLLER": "true",


In the workflow from the EP, the cluster-admin creates the gatewayclass, not Istio.

I can update that to say "Istio will only allow ...."

For reference: https://github.com/maistra/istio/blob/d8f16bb9d7e2671cf9bf70b1cf4cd314ced01ed0/pilot/pkg/features/pilot.go#L422

and https://redhat-internal.slack.com/archives/C01R9E3SFEV/p1706299854964029?thread_ts=1705959981.087229&cid=C01R9E3SFEV

Hm, so OSSM doesn't reconcile gatewayclasses at all without PILOT_ENABLE_GATEWAY_API_GATEWAYCLASS_CONTROLLER=true? Is that a regression from OSSM 2.4? Then it seems like the options are (1) no Gateway API support at all or (2) cluster-admin and OSSM clash over ownership of the default gatewayclass object. Option 2 is better if we have no other option.

Yes, it is a regression from OSSM 2.4. I could ask OSSM to try to fix it in a 2.5 patch, but they don't consider this a bug. I would like to get this into the next release if possible, if only to let dev preview users play with OSSM 2.5 as-is, but it doesn't add much to the mix in terms of Gateway API.

candita · 2024-04-10T15:31:37Z

/assign @rfredette
/assign @gcs278

- Pull the new CRD yaml from upstream and update pkg/manifests/assets/gateway-api - Update the pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go to reflect changes required by OSSM 2.5.

openshift-ci-robot · 2024-04-19T18:36:01Z

@candita: This pull request references NE-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

OSSM 2.5 supports Istio 1.18 and therefore only Gateway API v0.6.2 CRDS.

Pull the new CRD yaml from upstream and update pkg/manifests/assets/gateway-api

Update the pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go to reflect changes required by OSSM 2.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

candita · 2024-04-19T22:05:07Z

Was this an issue?

Querying https://api.integration.openshift.com/api/upgrades_info/graph?channel=candidate-4.16&arch=amd64 for version 4.16.0-0.ci.test-2024-04-19-184019-ci-op-q4j54j1m-latest
Version 4.16.0-0.ci.test-2024-04-19-184019-ci-op-q4j54j1m-latest is not available in candidate-4.16
Cluster cannot query OpenShift Update Service (OSUS/Cincinnati)

/test e2e-gcp-operator

candita · 2024-04-19T22:07:13Z

level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failure applying terraform for "cluster" stage: error applying Terraform configs: failed to apply Terraform: exit status 1
level=error
level=error msg=Error: waiting for EC2 Instance (i-071625d5fd2353bd2) create: couldn't find resource (21 retries)

/test e2e-aws-operator

rfredette · 2024-05-22T19:06:52Z

/lgtm

gcs278 · 2024-05-23T16:15:23Z

pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml

I tested this with our current DevPreview blog instructions: https://github.com/openshift/network-edge-tools/blob/main/docs/blogs/EnhancedDevPreviewGatewayAPI/GettingStarted.md.

And generally, everything looks good. However, the some blog instructions are now broken after this PR, for example:

OSSM will create two new Istio deployments in the openshift-ingress namespace we don't create the default istio-ingressgateway deployment, so this command is incorrect now.

The automated deployment and service name changed from demo-gateway to demo-gateway-openshift-default, some commands will fail

The ready condition doesn't exist, so the Wait for the gateway deployment to be ready: command will fail

Should we maintain our DevPreview blog instructions? Or let them go stale? Either way, I'm good with proceeding with this bump.

I noticed a couple of these too and made some notes on them. The DevPreview instructions are specific to a release. Hopefully we make enough progress with this release that we can issue an update in OpenShift docs.

gcs278 · 2024-05-23T16:16:02Z

Looks good to me.
/approve

openshift-ci · 2024-05-23T16:18:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gcs278]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-05-23T17:05:09Z

/retest-required

Remaining retests: 0 against base HEAD 487fe81 and 2 for PR HEAD d9a4fe9 in total

openshift-ci · 2024-05-23T18:33:47Z

@candita: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	`d9a4fe9`	link	false	`/test e2e-aws-ovn-single-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

candita · 2024-05-24T00:07:16Z

Failures in e2e-hypershift don't seem related to this change:

--- FAIL: TestCreateCluster (2454.22s)
--- PASS: TestCreateCluster/ValidateHostedCluster (1137.50s)
--- PASS: TestCreateCluster/ValidateHostedCluster/EnsureNodeCountMatchesNodePoolReplicas (0.09s)
--- PASS: TestCreateCluster/ValidateHostedCluster/EnsureNoCrashingPods (0.03s)
--- PASS: TestCreateCluster/ValidateHostedCluster/EnsureGuestWebhooksValidated (5.06s)
--- PASS: TestCreateCluster/ValidateHostedCluster/EnsureNodeCommunication (0.13s)
--- FAIL: TestCreateCluster/Main (765.27s)
--- FAIL: TestCreateCluster/Main/break-glass-credentials (600.41s)
--- FAIL: TestCreateCluster/Main/break-glass-credentials/independent_signers (600.41s)

Failure in e2e-aws-ovn-serial due to:

{ openshift cluster install failed with cluster creation}

/retest-required

openshift-bot · 2024-05-24T13:35:30Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.17.0-202405241212.p0.ga479bee.assembly.stream.el9 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 24, 2024

openshift-ci bot requested review from alebedev87 and rfredette January 24, 2024 20:19

candita force-pushed the NE-1400-Test-OSSM2.5 branch 2 times, most recently from 620ab5c to 5021078 Compare January 29, 2024 22:59

candita mentioned this pull request Feb 14, 2024

NE-1400: Add Gateway API v1.0.0 CRDs #999

Closed

candita force-pushed the NE-1400-Test-OSSM2.5 branch from 5021078 to d40c105 Compare February 14, 2024 19:42

candita changed the title ~~NE-1400: Test OSSM 2.5 with old Gateway API objects~~ NE-1400: Test OSSM 2.5 and Gateway API v0.6.2 CRDs Mar 20, 2024

candita force-pushed the NE-1400-Test-OSSM2.5 branch from d40c105 to fdd79f8 Compare March 20, 2024 22:48

candita changed the title ~~NE-1400: Test OSSM 2.5 and Gateway API v0.6.2 CRDs~~ NE-1400: Add OSSM 2.5 and Gateway API v0.6.2 CRDs Apr 10, 2024

candita changed the title ~~NE-1400: Add OSSM 2.5 and Gateway API v0.6.2 CRDs~~ NE-1400: Bump to OSSM 2.5 and Gateway API v0.6.2 CRDs Apr 10, 2024

Miciah reviewed Apr 10, 2024

View reviewed changes

openshift-ci bot assigned gcs278 and rfredette Apr 10, 2024

NE-1400: Bump to OSSM 2.5 and Gateway API CRDs (v0.6.2)

d9a4fe9

- Pull the new CRD yaml from upstream and update pkg/manifests/assets/gateway-api - Update the pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go to reflect changes required by OSSM 2.5.

candita force-pushed the NE-1400-Test-OSSM2.5 branch from fdd79f8 to d9a4fe9 Compare April 19, 2024 18:34

rfredette mentioned this pull request Apr 22, 2024

NE-1208: Gateway API E2E Testing #1023

Open

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024

gcs278 reviewed May 23, 2024

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024

openshift-merge-bot bot merged commit a479bee into openshift:master May 24, 2024
14 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NE-1400: Bump to OSSM 2.5 and Gateway API v0.6.2 CRDs #1018

NE-1400: Bump to OSSM 2.5 and Gateway API v0.6.2 CRDs #1018

candita commented Jan 24, 2024 •

edited

openshift-ci-robot commented Jan 24, 2024 •

edited by openshift-ci bot

candita commented Feb 27, 2024

candita commented Feb 27, 2024

openshift-ci-robot commented Mar 20, 2024 •

edited by openshift-ci bot

Miciah Apr 10, 2024

candita Apr 10, 2024

candita Apr 11, 2024 •

edited

Miciah Apr 17, 2024 •

edited

candita Apr 19, 2024

candita commented Apr 10, 2024

openshift-ci-robot commented Apr 19, 2024 •

edited by openshift-ci bot

candita commented Apr 19, 2024

candita commented Apr 19, 2024

rfredette commented May 22, 2024

gcs278 May 23, 2024

candita May 23, 2024

gcs278 commented May 23, 2024

openshift-ci bot commented May 23, 2024

openshift-ci-robot commented May 23, 2024

openshift-ci bot commented May 23, 2024 •

edited

candita commented May 24, 2024 •

edited

openshift-bot commented May 24, 2024

		// Istio will only create the default gateway class if this is true.
		"PILOT_ENABLE_GATEWAY_API_GATEWAYCLASS_CONTROLLER": "true",

NE-1400: Bump to OSSM 2.5 and Gateway API v0.6.2 CRDs #1018

NE-1400: Bump to OSSM 2.5 and Gateway API v0.6.2 CRDs #1018

Conversation

candita commented Jan 24, 2024 • edited

openshift-ci-robot commented Jan 24, 2024 • edited by openshift-ci bot

candita commented Feb 27, 2024

candita commented Feb 27, 2024

openshift-ci-robot commented Mar 20, 2024 • edited by openshift-ci bot

Miciah Apr 10, 2024

Choose a reason for hiding this comment

candita Apr 10, 2024

Choose a reason for hiding this comment

candita Apr 11, 2024 • edited

Choose a reason for hiding this comment

Miciah Apr 17, 2024 • edited

Choose a reason for hiding this comment

candita Apr 19, 2024

Choose a reason for hiding this comment

candita commented Apr 10, 2024

openshift-ci-robot commented Apr 19, 2024 • edited by openshift-ci bot

candita commented Apr 19, 2024

candita commented Apr 19, 2024

rfredette commented May 22, 2024

gcs278 May 23, 2024

Choose a reason for hiding this comment

candita May 23, 2024

Choose a reason for hiding this comment

gcs278 commented May 23, 2024

openshift-ci bot commented May 23, 2024

openshift-ci-robot commented May 23, 2024

openshift-ci bot commented May 23, 2024 • edited

candita commented May 24, 2024 • edited

openshift-bot commented May 24, 2024

candita commented Jan 24, 2024 •

edited

openshift-ci-robot commented Jan 24, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 20, 2024 •

edited by openshift-ci bot

candita Apr 11, 2024 •

edited

Miciah Apr 17, 2024 •

edited

openshift-ci-robot commented Apr 19, 2024 •

edited by openshift-ci bot

openshift-ci bot commented May 23, 2024 •

edited

candita commented May 24, 2024 •

edited