-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-14057: Add runbook urls for prometheus alerts. #1024
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8e914f7
to
3f04404
Compare
@miheer: This pull request references Jira Issue OCPBUGS-14057, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@miheer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/jira refresh |
@Miciah: This pull request references Jira Issue OCPBUGS-14057, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@Miciah: This pull request references Jira Issue OCPBUGS-14057, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tested it with 4.15.0-0.ci.test-2024-03-27-032758-ci-ln-izznskk-latest % oc get clusterversion % oc -n openshift-ingress-operator get PrometheusRule ingress-operator -oyaml | grep runbook_url |
/label qe-approved |
@miheer: This pull request references Jira Issue OCPBUGS-14057, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @Miciah |
@miheer we only need the runbook url for critical alerts. It would be better if you could enhance the one you wrote for HAProxyDown and removed the others, which are not needed. |
/hold until openshift/runbooks#166 merges |
Add runbook urls for prometheus alerts.
Ticket: https://issues.redhat.com/browse/OCPBUGS-14057