Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] NE-1531: AWS Subnet Selection #1046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] NE-1531: AWS Subnet Selection #1046

wants to merge 3 commits into from
+40,649 −12,183

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Apr 18, 2024 •
edited

Adds implementation for AWS subnet selection API. Take the subnets specified by on the IngressController and propagate them to the service.beta.kubernetes.io/aws-load-balancer-subnets annotation on the LB-type Service.

This design requires a cluster admin to manually delete the LB-type Service in order to effectuate the subnet update. Once an subnet update is made on the IngressController, a LoadBalancerProgressing=True condition will be added to notify the cluster admin to delete the Service.

This change is being introduced under the Tech Preview IngressControllerLBSubnetsAWS feature gate and will be later promoted to GA.

Epic: https://issues.redhat.com/browse/NE-705
EP: openshift/enhancements#1595
API: openshift/api#1841

WIP:

  • Waiting for the API to merge and for 4.17 branch to open

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2024 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Implements https://issues.redhat.com/browse/NE-705

EP: openshift/enhancements#1595
API: openshift/api#1841

WIP:

  • Waiting for agreement on the EP.
  • Waiting for the API to merge
  • Need E2E testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@openshift-ci openshift-ci bot requested review from frobware and Miciah April 18, 2024 23:12
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch from 92b78fb to 511c25a Compare April 22, 2024 17:37
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 22, 2024 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Implements https://issues.redhat.com/browse/NE-705

EP: openshift/enhancements#1595
API: openshift/api#1841

WIP:

  • Waiting for agreement on the EP.
  • Waiting for the API to merge
  • Need E2E testing
  • Some implementation choices should be revisited (such as which function we should configure status.endpointPublishingStrategy.loadBalancer.providerParameters.aws.subnets in)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch from 511c25a to a322e63 Compare April 22, 2024 17:54
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 3 times, most recently from 8168487 to 044c94f Compare April 24, 2024 03:37
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Implements https://issues.redhat.com/browse/NE-705

EP: openshift/enhancements#1595
API: openshift/api#1841

WIP:

  • Waiting for agreement on the EP.
  • Waiting for the API to merge
  • Some implementation choices should be revisited (such as which function we should configure status.endpointPublishingStrategy.loadBalancer.providerParameters.aws.subnets in)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 2, 2024 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Implements https://issues.redhat.com/browse/NE-705

EP: openshift/enhancements#1595
API: openshift/api#1841

WIP:

  • Waiting for agreement on the EP.
  • Waiting for the API to merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 2 times, most recently from 672e37f to 0b0e60a Compare May 2, 2024 22:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 7 times, most recently from d87422f to 9bd1774 Compare May 9, 2024 05:05
@gcs278
Copy link
Contributor Author

gcs278 commented May 9, 2024

TODO need to fix verify job

@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 3 times, most recently from 13a29ff to 82aaba9 Compare May 14, 2024 04:08
@gcs278
Copy link
Contributor Author

gcs278 commented May 14, 2024

Appears like infrastructure issues:
/retest-required

@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 2 times, most recently from 499c770 to b12a3a3 Compare May 15, 2024 03:02
@gcs278 gcs278 mentioned this pull request May 15, 2024
Merged
@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 3 times, most recently from 3e7471c to 6cb3cb2 Compare May 15, 2024 17:33
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2024 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adds implementation for AWS subnet selection API. Take the subnets specified by on the IngressController and propagate them to the service.beta.kubernetes.io/aws-load-balancer-subnets annotation on the LB-type Service.

This design requires a cluster admin to manually delete the LB-type Service in order to effectuate the subnet update. Once an subnet update is made on the IngressController, a LoadBalancerProgressing=True condition will be added to notify the cluster admin to delete the Service.

This change is being introduced under the Tech Preview IngressControllerLBSubnetsAWS feature gate and will be later promoted to GA.

Epic: https://issues.redhat.com/browse/NE-705
EP: openshift/enhancements#1595
API: openshift/api#1841

WIP:

  • Waiting for the API to merge and for 4.17 branch to open

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 3 times, most recently from 527a50c to 8f0c944 Compare May 15, 2024 19:40
@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch 2 times, most recently from 928571a to 15ef66f Compare May 23, 2024 20:17
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@gcs278
Update e2e function updateIngressControllerSpecWithRetryOnConflict
ed98a3b 
Change e2e function updateIngressControllerSpecWithRetryOnConflict to
updateIngressControllerWithRetryOnConflict and make it support mutating
an entire IngressController object, not just the spec. This will allow
e2e tests to use this function to update IngressController annotations.
@gcs278
Bump openshift/api, update CRD generation
3a1ec58 
Bump openshift/api to add support for AWS Subnet API:

    go mod edit -replace=github.com/openshift/api=github.com/openshift/api@<TBD>
    go mod tidy
    go mod vendor
    make update

Update hack/update-generated-crd.sh and hack/verify-generated-crd.sh due
to the 0000_50_ingress_00_ingresscontrollers.crd.yaml file getting
separated into manifests for Default, CustomNoUpgrade, DevPreviewNoUpgrade,
and TechPreviewNoUpgrade Feature Sets.
@gcs278
NE-1531: Add LB Subnet Selection for AWS
925cd04 
Adds implementation for AWS subnet selection API. Take the subnets
specified by on the IngressController and propagate them to the
service.beta.kubernetes.io/aws-load-balancer-subnets annotation on the
LB-type Service.

This design requires a cluster admin to manually delete the LB-type
Service in order to effectuate the subnet update. Once an subnet update
is made on the IngressController, a LoadBalancerProgressing=True
condition will be added to notify the cluster admin to delete the
Service.

This change is being introduced under the Tech Preview
IngressControllerLBSubnetsAWS feature gate and will be later promoted to
GA.
@gcs278 gcs278 force-pushed the NE705-aws-subnet-selection branch from 15ef66f to 925cd04 Compare May 23, 2024 20:23
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@gcs278
Copy link
Contributor Author

gcs278 commented May 28, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 925cd04 link false /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-techpreview 925cd04 link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-azure-ovn 925cd04 link false /test e2e-azure-ovn
ci/prow/e2e-aws-gatewayapi 925cd04 link false /test e2e-aws-gatewayapi
ci/prow/e2e-aws-operator-techpreview 925cd04 link false /test e2e-aws-operator-techpreview
ci/prow/e2e-aws-ovn-single-node 925cd04 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator 925cd04 link true /test e2e-gcp-operator
ci/prow/e2e-aws-ovn-serial 925cd04 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-upgrade 925cd04 link true /test e2e-aws-ovn-upgrade
ci/prow/unit 925cd04 link true /test unit
ci/prow/verify 925cd04 link true /test verify
ci/prow/images 925cd04 link true /test images
ci/prow/e2e-azure-operator 925cd04 link true /test e2e-azure-operator
ci/prow/e2e-aws-ovn 925cd04 link true /test e2e-aws-ovn
ci/prow/e2e-aws-operator 925cd04 link true /test e2e-aws-operator
ci/prow/e2e-hypershift 925cd04 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@Miciah Miciah Awaiting requested review from Miciah

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gcs278 @openshift-ci-robot @openshift-merge-robot