Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-5471: Fix stale metrics in telemetry #2458

Merged

Conversation

xperimental
Copy link
Contributor

@xperimental xperimental commented Apr 30, 2024

Description

This is a backport of #2443 to release-5.8, to be reviewed/merged after the review of that PR finishes.

/cc @jcantrill
/assign @cahartma

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024

@xperimental: This pull request references LOG-5471 which is a valid jira issue.

In response to this:

Description

This is a backport of #2443 to release-5.8, to be reviewed/merged after the review of that PR finishes.

/cc @jcantrill
/assign @cahartma

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xperimental
Copy link
Contributor Author

/hold

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024

@xperimental: This pull request references LOG-5471 which is a valid jira issue.

In response to this:

Description

This is a backport of #2443 to release-5.8, to be reviewed/merged after the review of that PR finishes.

/cc @jcantrill
/assign @cahartma

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024

@xperimental: This pull request references LOG-5471 which is a valid jira issue.

In response to this:

Description

This is a backport of #2443 to release-5.8, to be reviewed/merged after the review of that PR finishes.

/cc @jcantrill
/assign @cahartma

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xperimental
Copy link
Contributor Author

/retest-required

@xperimental
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@xperimental
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3bbdab7 into openshift:release-5.8 May 15, 2024
10 checks passed
@xperimental xperimental deleted the refactor-telemetry-5.8 branch May 16, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants