LOG-2811: Add lokistack output type to cluster forwarder #2483
Conversation
|
@Clee2691: This pull request references LOG-2811 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test all |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
There was a problem hiding this comment.
Apart from a comment on the auth debate, this looks good.
Generating extra outputs and pipelines is somewhat complex but I think it is the only option right now - vector doesn't support any way to vary the base URL per message.
I'd like the code to be simpler, but I don't have any good idea how to do that right now....
Clee2691
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
api/observability/v1/output_types.go
Outdated
| // to allow dynamic per-event values. Defaults to the log type (i.e. application, audit, infrastructure) | ||
| // | ||
| // +kubebuilder:validation:Required | ||
| // +kubebuilder:default:={{.log_type}} |
There was a problem hiding this comment.
I think we discovered this needs quote? Is that right?
| } | ||
|
|
||
| // hasLokiStackOutput checks if a pipeline includes a lokistack output | ||
| func hasLokiStackOutput(outputMap map[string]*obs.OutputSpec, outputRefs []string) *sets.String { |
There was a problem hiding this comment.
nit. since we need to change the other thing maybe make this plural?
There was a problem hiding this comment.
I changed the name of this function to better represent what it does: findLokiStackOutputs()
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Clee2691, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@Clee2691: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Lokito use observability APILokioutput to APILokiStackoutput toLokioutputs crafting the URL with the tenant (current behavior of LokiStack)/cc
/assign
Links