LOG-5042: Refactor Collector Alerts/Metrics according to changes in 6.0 version #2484
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vparfonov: This pull request references LOG-5042 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vparfonov: This pull request references LOG-5042 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
needs-rebase
openshift-merge-robot
added
the
needs-rebase
vparfonov
force-pushed
the
log5042
branch
2 times, most recently
from
15d121e
to
f7c8269
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@vparfonov: This pull request references LOG-5042 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -117,15 +105,12 @@ spec: | |||
| severity: Warning | |||
| - name: logging_clusterlogging_telemetry.rules | |||
| rules: | |||
| - expr: | | |||
There was a problem hiding this comment.
is this only a recording rule from the fluent metrics? I thought this was in place to normalize some of our queries so they were collector agnostic
There was a problem hiding this comment.
Yes this rule used only for Fluentd, but for Vector we have vector_component_received_bytes_total(24h)
| for: 1h | ||
| labels: | ||
| service: collector | ||
| severity: Warning | ||
| - alert: ElasticsearchDeprecation | ||
| annotations: | ||
| message: "The OpenShift Elasticsearch Operator is deprecated and is planned to be removed in a future release. Red Hat provides bug fixes and support for this feature during the current release lifecycle, but this feature no longer receives enhancements. As an alternative to using the OpenShift Elasticsearch Operator to manage the default log storage, you can use the Loki Operator." |
There was a problem hiding this comment.
We should update this statement since THIS is the release where we are removing it.
There was a problem hiding this comment.
Yes, i want ask about that
| @@ -98,15 +88,16 @@ spec: | |||
| severity: Warning | |||
| - name: logging_clusterlogging_telemetry.rules | |||
| rules: | |||
| - expr: | | |||
There was a problem hiding this comment.
same comment as previous...is this metric only available from fluentd metrics?
| @@ -64,24 +64,14 @@ | |||
| }, | |||
| "targets": [ | |||
| { | |||
| "expr": "sum by(job, namespace, app_kubernetes_io_name) (increase(vector_component_received_bytes_total{component_kind=\"source\", component_type!=\"internal_metrics\"}[24h]))", | |||
| "legendFormat": "{{namespace}}/{{job}}/{{app_kubernetes_io_name}}", | |||
| "expr": "sum by(namespace, app_kubernetes_io_instance) (increase(vector_component_received_bytes_total{component_kind=\"source\", component_type!=\"internal_metrics\"}[24h]))", | |||
There was a problem hiding this comment.
remind me what was the value we added to "..._io_name" ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vparfonov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@vparfonov: This pull request references LOG-5042 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
vparfonov
force-pushed
the
log5042
branch
4 times, most recently
from
8e3d02a
to
68bebf7
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
….0 version Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
openshift-merge-robot
removed
the
needs-rebase
|
/cc @libander |
|
@vparfonov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
In this PR:
Fluentdcollector:FluentdQueueLengthIncreasingVectorcollector, removed dependencies onFluentdapp_kubernetes_io_instancelabel, this should help accurate determination of the CLF instance/cc @Clee2691 @cahartma
/assign @jcantrill
/cherry-pick
Links