LOG-5515: Refactor syslog to use OBS API #2489
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jcantrill: This pull request references LOG-5515 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jcantrill
added
release/6.0
and removed
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| AppName: AppName(o.Syslog), | ||
| ProcID: ProcID(o.Syslog), | ||
| MsgID: MsgID(o.Syslog), | ||
| Tag: Tag(o.Syslog), |
There was a problem hiding this comment.
What happened to the Tag, LogSource, and PayloadKey?
There was a problem hiding this comment.
What happened to the
Tag,LogSource, andPayloadKey?
I removed them based upon a conversation where I wish to move away from any special behavior, but I'm questioning if this was the right call. I actually am wondering if it makes sense to not offer them but if we should be doing some transformation to fill in these fields based record content, or continue to offer them as-is and allow the admin to choose. We should discuss.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
@jcantrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Description
This PR:
Links
@Clee2691 @cahartma @vparfonov